Skip to content

Solution and Test for issue #34 - #107

Merged
msach22 merged 2 commits into
llipio:masterfrom
Himanshu1495:repeat-element
Jul 7, 2017
Merged

Solution and Test for issue #34#107
msach22 merged 2 commits into
llipio:masterfrom
Himanshu1495:repeat-element

Conversation

@Himanshu1495

Copy link
Copy Markdown
Contributor

@songz , I have created the solution and tests for issue #34. Please review it.

Comment thread test/34.py
import unittest


class MyTest(unittest.TestCase):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the test. Could you come up with a better name? RepeatingElementsTest

Comment thread test/34.py
'''
import sys
sys.path.insert(0,'../solutions/')
from sol34 import repeating_element

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you rename to just do 34

Comment thread solutions/sol34.py
@@ -0,0 +1,13 @@
#Himanshu Nachane (@Himanshu1495)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename file. 34.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, saw your other comment. Thanks.

@msach22
msach22 merged commit 80bf94a into llipio:master Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants