docs(uploads): four-mode upload recipes + nav (#67) - #74
Merged
Conversation
Bring the docs-site upload recipes onto the four-mode `Mode` API shipped in livetemplate v0.13.0: - go.mod: bump livetemplate v0.12.0 -> v0.13.0 (the release that ships the four upload modes), matching the reference doc's source_ref. - recipes/apps/avatar-upload.md: rewrite to mirror the (already-modern) example, framed as the default Volume mode. Drops the long-removed AllowUploads/ConsumeUpload API, hardcoded /Users paths, and v0.3.0 refs. - recipes/apps/upload-modes.md: new recipe walking all four modes (Volume / Direct / Proxied / Preview), pointing at examples/upload-modes/. - recipes/ui-patterns/forms/file-upload.md: name the default Volume mode and link the four-mode reference + new recipe. - tinkerdown.yaml + recipes/apps/index.md: register the Upload Modes page. The mirrored content/reference/uploads.md is owned by cmd/sync and lands via the v0.13.0 sync PR (#72); this PR deliberately does not touch it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes 3 of the 5 tasks in #67 — the docs-native recipes + nav + the
go.modbump. The other two (rewritecontent/reference/uploads.md, runcmd/sync) are mirrored content owned by the sync pipeline and landed via #72 (livetemplate@v0.13.0) + #73 (client@v0.13.0), both now merged. This PR deliberately does not touchcontent/reference/uploads.md.Changes
go.mod— bumplivetemplatev0.12.0 → v0.13.0 (the release that ships the four upload modes), matching the reference doc'ssource_ref.recipes/apps/avatar-upload.md— rewritten to mirror the (already-modern)examples/avatar-upload/code, framed as the default Volume mode. Drops the long-removedAllowUploads/ConsumeUploadAPI, hardcoded/Userspaths, andv0.3.0references.recipes/apps/upload-modes.md— new recipe walking all four modes (Volume / Direct / Proxied / Preview), pointing atexamples/upload-modes/.recipes/ui-patterns/forms/file-upload.md— names the default Volume mode and links the four-mode reference + new recipe.tinkerdown.yaml+recipes/apps/index.md— register the Upload Modes page.Verification
tinkerdown validate content/— 94/94, 0 errors; the three touched/added pages validate.cd cmd/sync && go test ./...andGOWORK=off go build ./...+go mod tidy— clean.TestSpine*failures seen locally are environmental (server-push/WebSocket through a local Docker bridge), not from this change: the v0.13.0 diff is upload-only,main's CI e2e is green, and a pristine v0.12.0 image fails the same 4 identically.Remaining for #67 (follow-up, not in this PR)
The
upload-modesexample's browser E2E is gated behindLVT_UPLOAD_MODES_E2E+LVT_LOCAL_CLIENT(unset in CI), and its skip message citesdocs#67as the issue to "integrate it into the CI harness." Docs CI runse2e/...only, neverexamples/..., so that test currently runs nowhere. Wiring it in needs the client bundle + a CI job — suggest a dedicated follow-up issue rather than expanding this PR.🤖 Generated with Claude Code