Skip to content

fix: harden release script with clean build and verification #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adnaan merged 3 commits into from
Mar 29, 2026
Merged

fix: harden release script with clean build and verification #37

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8b2d88
fix: harden release script with clean build and verification
adnaan Mar 29, 2026
75f87c3
fix: address bot review comments
adnaan Mar 29, 2026
f260b39
fix: drop leading slash in grep pattern for npm pack verification
adnaan Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,12 @@ build_and_test() {
}
log_info "Tests passed"

log_step "Cleaning previous build artifacts..."
npm run clean || {
log_error "Clean failed, aborting release"
exit 1
}

log_step "Building TypeScript client..."
npm run build || {
log_error "Build failed, aborting release"
Expand All @@ -226,6 +232,65 @@ build_and_test() {
log_info "Client built successfully"
}

# Verify build artifacts
verify_build() {
local new_version=$1
log_step "Verifying build artifacts..."

local required_files=(
"dist/livetemplate-client.js"
"dist/livetemplate-client.d.ts"
"dist/livetemplate-client.browser.js"
)
for f in "${required_files[@]}"; do
if [ ! -s "$f" ]; then
log_error "Missing or empty build artifact: $f"
exit 1
fi
done
log_info "All required dist files present"

node -e "
const m = require('./dist/livetemplate-client.js');
if (!m.LiveTemplateClient) process.exit(1);
" || {
log_error "Smoke test failed: module doesn't export LiveTemplateClient"
exit 1
}
log_info "Smoke test passed"

local pkg_version
pkg_version=$(jq -r '.version' package.json)
if [ "$pkg_version" != "$new_version" ]; then
log_error "package.json version ($pkg_version) != expected ($new_version)"
exit 1
fi

log_info "Build verification passed"
}

# Verify npm package contents before publishing
verify_package_contents() {
log_step "Verifying npm package contents..."

local pack_output
pack_output=$(npm pack --dry-run 2>&1)

local required_in_pack=(
"dist/livetemplate-client.js"
"dist/livetemplate-client.d.ts"
"dist/livetemplate-client.browser.js"
)
for f in "${required_in_pack[@]}"; do
if ! echo "$pack_output" | grep -qF "$f"; then
log_error "npm pack missing required file: $f"
exit 1
Comment on lines +284 to +287

Copilot AI Mar 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grep -q "$f" check can produce false positives (e.g., dist/livetemplate-client.js will also match dist/livetemplate-client.js.map). This undermines the verification goal—consider matching the exact filename at end-of-line, using fixed-string matching, or parsing npm pack --dry-run --json output to reliably assert required files are included.

Copilot uses AI. Check for mistakes.
fi
done

log_info "Package contents verified"
}

# Publish to npm
publish_npm() {
local new_version=$1
Expand Down Expand Up @@ -519,6 +584,8 @@ main() {
update_versions "$new_version"
generate_changelog "$new_version"
build_and_test
verify_build "$new_version"
verify_package_contents
commit_and_tag "$new_version"
publish_npm "$new_version"
publish_github "$new_version"
Expand Down
Loading