Skip to content

Fixes#974

Merged
hatemhosny merged 2 commits into
developfrom
fixes
May 12, 2026
Merged

Fixes#974
hatemhosny merged 2 commits into
developfrom
fixes

Conversation

@hatemhosny
Copy link
Copy Markdown
Collaborator

@hatemhosny hatemhosny commented May 12, 2026

Summary by CodeRabbit

  • Chores
    • Refined Docker build configuration to optimize build context and improve dependency resolution efficiency
    • Updated Storybook package handling to separately manage server dependencies and framework-specific configurations
    • Enhanced development tooling configuration to exclude specific Storybook files from linting analysis

Review Change Stack

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026

Deploy Preview for livecodes ready!

Name Link
🔨 Latest commit e3c01e0
🔍 Latest deploy log https://app.netlify.com/projects/livecodes/deploys/6a02ffe4b134c90008f9accc
😎 Deploy Preview https://deploy-preview-974--livecodes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2d2d6d28-2fd3-48c3-804c-323367fa9ed1

📥 Commits

Reviewing files that changed from the base of the PR and between 9438aaa and e3c01e0.

📒 Files selected for processing (3)
  • .dockerignore
  • Dockerfile
  • eslint.config.mjs

Walkthrough

The PR updates Docker build configuration and linting rules to accommodate a refactored Storybook directory structure. The .dockerignore file uses a root-anchored node_modules pattern, the Dockerfile builder stage now copies framework-specific Storybook package manifests separately, and ESLint ignores generated LiveCode files in the Storybook directories.

Changes

Build and Linting Configuration

Layer / File(s) Summary
Docker build context for refactored Storybook
.dockerignore, Dockerfile
.dockerignore anchors the /node_modules exclusion at the repository root; Dockerfile builder stage separates server/package*.json copying and replaces the single Storybook copy with framework-specific COPY commands for storybook/preact, storybook/react, storybook/solid, storybook/svelte, storybook/vue, and storybook/web-components.
ESLint ignore pattern for generated files
eslint.config.mjs
ESLint configuration adds storybook/**/src/livecodes*.ts to the top-level ignores list to exclude generated files from linting checks.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fixes' is vague and does not clearly summarize the specific changes made to the pull request. Consider using a more descriptive title that explains the primary change, such as 'Update Docker and ESLint configuration for Storybook packages' or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size Change
build/404.html 1 kB 0 B
build/app.html 250 B 0 B
build/index.html 2.47 kB -1 B (-0.04%)
build/livecodes/app.css 22.6 kB 0 B
build/livecodes/app.js 113 kB -91 B (-0.08%)
build/livecodes/assets.js 8.66 kB 0 B
build/livecodes/assets/noop.js 18 B 0 B
build/livecodes/assets/templates/diagrams-starter.html 2.19 kB 0 B
build/livecodes/backup.js 3.74 kB +1 B (+0.03%)
build/livecodes/blockly.js 15.1 kB 0 B
build/livecodes/broadcast.js 1.19 kB +1 B (+0.08%)
build/livecodes/bundle-types.js 4.41 kB 0 B
build/livecodes/code-to-image.js 9.15 kB -9 B (-0.1%)
build/livecodes/codejar.js 17.6 kB 0 B
build/livecodes/codemirror.js 16.2 kB 0 B
build/livecodes/compile.page.js 2.45 kB 0 B
build/livecodes/compile.worker.js 15.2 kB 0 B
build/livecodes/compiler-utils.js 3.17 kB 0 B
build/livecodes/custom-editor-utils.js 198 B 0 B
build/livecodes/deploy.js 6.92 kB -16 B (-0.23%)
build/livecodes/editor-settings.js 19.4 kB +24 B (+0.12%)
build/livecodes/embed-ui.js 5.51 kB -1 B (-0.02%)
build/livecodes/embed.js 91.3 kB +24 B (+0.03%)
build/livecodes/export.js 3.91 kB 0 B
build/livecodes/firebase.js 22.7 kB 0 B
build/livecodes/format.worker.js 14.5 kB 0 B
build/livecodes/google-fonts.js 7.12 kB 0 B
build/livecodes/headless.js 79.7 kB -40 B (-0.05%)
build/livecodes/i18n-ar-language-info.json 5.34 kB 0 B
build/livecodes/i18n-ar-translation.json 9.33 kB 0 B
build/livecodes/i18n-bn-language-info.json 5.76 kB 0 B
build/livecodes/i18n-bn-translation.json 9.66 kB 0 B
build/livecodes/i18n-de-language-info.json 5.4 kB 0 B
build/livecodes/i18n-de-translation.json 9.46 kB 0 B
build/livecodes/i18n-en-language-info.json 4.63 kB 0 B
build/livecodes/i18n-en-translation.json 8.05 kB 0 B
build/livecodes/i18n-es-language-info.json 5.12 kB 0 B
build/livecodes/i18n-es-translation.json 9.19 kB 0 B
build/livecodes/i18n-fa-language-info.json 5.52 kB 0 B
build/livecodes/i18n-fa-translation.json 9.49 kB 0 B
build/livecodes/i18n-fr-language-info.json 5.31 kB 0 B
build/livecodes/i18n-fr-translation.json 9.43 kB 0 B
build/livecodes/i18n-hi-language-info.json 5.93 kB 0 B
build/livecodes/i18n-hi-translation.json 9.98 kB 0 B
build/livecodes/i18n-id-language-info.json 4.87 kB 0 B
build/livecodes/i18n-id-translation.json 8.71 kB 0 B
build/livecodes/i18n-it-language-info.json 5.17 kB 0 B
build/livecodes/i18n-it-translation.json 9.26 kB 0 B
build/livecodes/i18n-ja-language-info.json 5.72 kB 0 B
build/livecodes/i18n-ja-translation.json 9.64 kB 0 B
build/livecodes/i18n-nl-language-info.json 5.07 kB 0 B
build/livecodes/i18n-nl-translation.json 8.91 kB 0 B
build/livecodes/i18n-pt-language-info.json 5.16 kB 0 B
build/livecodes/i18n-pt-translation.json 9.38 kB 0 B
build/livecodes/i18n-ru-language-info.json 5.7 kB 0 B
build/livecodes/i18n-ru-translation.json 10.3 kB 0 B
build/livecodes/i18n-tr-language-info.json 5.3 kB 0 B
build/livecodes/i18n-tr-translation.json 9.28 kB 0 B
build/livecodes/i18n-ur-language-info.json 5.97 kB 0 B
build/livecodes/i18n-ur-translation.json 9.81 kB 0 B
build/livecodes/i18n-zh-CN-language-info.json 5.01 kB 0 B
build/livecodes/i18n-zh-CN-translation.json 8.67 kB 0 B
build/livecodes/i18n.js 20.3 kB -59 B (-0.29%)
build/livecodes/import-src.js 17.9 kB 0 B
build/livecodes/import.js 16.3 kB +17 B (+0.1%)
build/livecodes/index.js 5.43 kB +20 B (+0.37%)
build/livecodes/lang-art-template-compiler.js 1.68 kB 0 B
build/livecodes/lang-assemblyscript-compiler.js 290 B 0 B
build/livecodes/lang-assemblyscript-script.js 386 B 0 B
build/livecodes/lang-astro-compiler.js 2.37 kB 0 B
build/livecodes/lang-clio-compiler.js 1.58 kB 0 B
build/livecodes/lang-commonlisp-script.js 123 B 0 B
build/livecodes/lang-cpp-script.js 1.96 kB 0 B
build/livecodes/lang-cpp-wasm-script.js 2.88 kB 0 B
build/livecodes/lang-csharp-wasm-script.js 2.21 kB 0 B
build/livecodes/lang-diagrams-compiler-esm.js 5.11 kB 0 B
build/livecodes/lang-dot-compiler.js 1.69 kB 0 B
build/livecodes/lang-ejs-compiler.js 1.66 kB 0 B
build/livecodes/lang-eta-compiler.js 1.68 kB 0 B
build/livecodes/lang-fennel-compiler.js 1.64 kB 0 B
build/livecodes/lang-gleam-compiler.js 3.12 kB 0 B
build/livecodes/lang-go-wasm-script.js 3.29 kB 0 B
build/livecodes/lang-haml-compiler.js 1.69 kB 0 B
build/livecodes/lang-handlebars-compiler.js 1.99 kB 0 B
build/livecodes/lang-imba-compiler.js 147 B 0 B
build/livecodes/lang-java-script.js 4.09 kB 0 B
build/livecodes/lang-jinja-compiler.js 1.67 kB 0 B
build/livecodes/lang-julia-script.js 3.32 kB 0 B
build/livecodes/lang-liquid-compiler.js 1.71 kB 0 B
build/livecodes/lang-lua-wasm-script.js 205 B 0 B
build/livecodes/lang-malina-compiler.js 2.98 kB 0 B
build/livecodes/lang-markdown-compiler.js 1.7 kB 0 B
build/livecodes/lang-markdown-script.js 1.47 kB 0 B
build/livecodes/lang-minizinc-script.js 2.09 kB 0 B
build/livecodes/lang-mustache-compiler.js 1.68 kB 0 B
build/livecodes/lang-nunjucks-compiler.js 2 kB 0 B
build/livecodes/lang-perl-script.js 268 B 0 B
build/livecodes/lang-php-wasm-script.js 347 B 0 B
build/livecodes/lang-postgresql-compiler-esm.js 1.76 kB 0 B
build/livecodes/lang-prolog-script.js 204 B 0 B
build/livecodes/lang-pug-compiler.js 371 B 0 B
build/livecodes/lang-python-wasm-script.js 1.89 kB 0 B
build/livecodes/lang-r-script-esm.js 2.47 kB 0 B
build/livecodes/lang-rescript-compiler-esm.js 2.19 kB 0 B
build/livecodes/lang-rescript-formatter.js 1.55 kB 0 B
build/livecodes/lang-riot-compiler.js 2.84 kB 0 B
build/livecodes/lang-ruby-wasm-script.js 1.75 kB 0 B
build/livecodes/lang-scss-compiler.js 1.85 kB 0 B
build/livecodes/lang-solid-compiler.js 263 B 0 B
build/livecodes/lang-sql-compiler.js 1.67 kB 0 B
build/livecodes/lang-sql-script.js 2.07 kB 0 B
build/livecodes/lang-svelte-compiler.js 4.72 kB 0 B
build/livecodes/lang-tcl-script.js 1.86 kB 0 B
build/livecodes/lang-teal-compiler.js 1.75 kB 0 B
build/livecodes/lang-twig-compiler.js 1.68 kB 0 B
build/livecodes/lang-vento-compiler.js 1.73 kB 0 B
build/livecodes/lang-vue-compiler.js 6.13 kB 0 B
build/livecodes/lang-vue2-compiler.js 3.5 kB 0 B
build/livecodes/lang-wat-compiler.js 348 B 0 B
build/livecodes/lang-wat-script.js 1.98 kB 0 B
build/livecodes/language-info.js 7.92 kB -2 B (-0.03%)
build/livecodes/monaco.js 20 kB 0 B
build/livecodes/open.js 6.24 kB -1 B (-0.02%)
build/livecodes/processor-lightningcss-compiler.js 1.91 kB 0 B
build/livecodes/processor-postcss-compiler.js 2.06 kB 0 B
build/livecodes/processor-tailwindcss-compiler.js 5.29 kB 0 B
build/livecodes/processor-unocss-compiler.js 355 B 0 B
build/livecodes/processor-windicss-compiler.js 450 B 0 B
build/livecodes/quill.css 697 B 0 B
build/livecodes/quill.js 5.86 kB 0 B
build/livecodes/resources.js 3.43 kB 0 B
build/livecodes/result-utils.js 1.17 kB 0 B
build/livecodes/share.js 3.85 kB +2 B (+0.05%)
build/livecodes/snippets.js 6.08 kB +1 B (+0.02%)
build/livecodes/sync-ui.js 3.29 kB 0 B
build/livecodes/sync.js 3.56 kB 0 B
build/livecodes/sync.worker.js 29.8 kB 0 B
build/livecodes/templates.js 27 kB 0 B
build/sdk/livecodes.js 4.39 kB 0 B
build/sdk/livecodes.umd.js 5.19 kB 0 B
build/sdk/package.json 456 B 0 B
build/sdk/preact.js 4.74 kB 0 B
build/sdk/react.js 4.77 kB 0 B
build/sdk/solid.js 4.91 kB 0 B
build/sdk/svelte.js 4.36 kB 0 B
build/sdk/vue.js 4.77 kB 0 B
build/sdk/web-components.js 5.8 kB 0 B

compressed-size-action

@hatemhosny hatemhosny merged commit 8ae0218 into develop May 12, 2026
28 of 29 checks passed
@hatemhosny hatemhosny deleted the fixes branch May 12, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant