Skip to content

Enable optional USB keyboard for all current and future boarfs (Requires on-demand enablement through Config Options + flash to persist across reboot/firmware upgrades) - #1838

Merged
JonathonHall-Purism merged 3 commits into
linuxboot:masterfrom
tlaurion:enable-optional_usb_keyboard_for_all
Nov 6, 2024

Conversation

@tlaurion

@tlaurion tlaurion commented Nov 5, 2024

Copy link
Copy Markdown
Collaborator

Fixes #1780

  • Enables usb hid kernel module to be packed under modules.cpio unconditionally (build errors for board linux config not packing usb hid from CircleCI if not compiled as module or path changed between kernel bumps)
  • change config settings script so that usb support is taken for granted (under modules.cpio per build time guarantee)
    • menu toggle to turn on/off USB Keyboard support (warning is explicit), sets user desired usb keyboard as variable exported, no module usb keyboard module loaded until reboot:
      • Requires flashing resulting config.user to cbfs, which makes the setting persisten across reboot/upgrades.
      • It's possible to disable, requiring the same flashing of config.user file to CBFS to not be applied on reboot (=n)
  • Removes usb support in boards that were asking now deprecated support from board config (librems)

@JonathonHall-Purism please review

…ll boards (linux_modules-y for usbhid.ko)

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…D since usbhid.ko packed for all boards. Menu now permits turning on keyboard from internal, non-usb keyboard or force support through CONFIG_USB_KEYBOARD_REQUIRED=y under board configs

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…ed by default if kernel config enable it as compiled as module

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
@tlaurion tlaurion changed the title Enable optional usb keyboard for all Enable optional USB keyboard for all current and future boarfs (Requires on-demand enablement through Config Options + flash to persist across reboot) Nov 5, 2024
@tlaurion tlaurion changed the title Enable optional USB keyboard for all current and future boarfs (Requires on-demand enablement through Config Options + flash to persist across reboot) Enable optional USB keyboard for all current and future boarfs (Requires on-demand enablement through Config Options + flash to persist across reboot/firmware upgrades) Nov 5, 2024
@tlaurion
tlaurion marked this pull request as draft November 5, 2024 20:52
@tlaurion
tlaurion marked this pull request as ready for review November 5, 2024 21:23
@tlaurion

tlaurion commented Nov 5, 2024

Copy link
Copy Markdown
Collaborator Author

Tested on w530. Ready to merge whenever you are @JonathonHall-Purism . You can press the merge button after approving.

We should probably bring the Configuration Settings menu more up in the list of Settings.

@marmarek

marmarek commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

I haven't tested this version, but looks okay and should solve my needs.

@JonathonHall-Purism JonathonHall-Purism left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks @tlaurion . Looks perfect, merging now

@JonathonHall-Purism
JonathonHall-Purism merged commit 5aa1243 into linuxboot:master Nov 6, 2024
@tlaurion tlaurion mentioned this pull request Sep 19, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants