flake.nix + qemu.mk : add working qemu-canokey usable from all qemu boards by default - #1671
Merged
Merged
Conversation
…oards by default flake.nix: add canokey-qemu lib, derivate qemu on tope of it and have qemu_kvm depend on qemu derivative targets/qemu.mk: modified to had canokey support by default if no "USB_TOKEN=" specified on make run call CircleCI: base docker image pull on v0.1.6 containing the newly added derivatives Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Collaborator
Author
|
To test and replicate: Follow: |
Collaborator
Author
|
@JonathonHall-Purism quick review, doesn't change much but canokey being usable if no usb security token being passed in make run call |
JonathonHall-Purism
approved these changes
May 13, 2024
JonathonHall-Purism
left a comment
JonathonHall-Purism
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine 👍
This was referenced May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1670
Closes #1207
Finally, bye errors of qemu TCG on top of qemu on top of qubesos with usb error -32.
It's alive!!!
Someone.... wants to implement reverse HOTP inside of canokey-qemu???