Skip to content

Improvements on xx30 vbios scripts - #1111

Merged
tlaurion merged 1 commit into
linuxboot:masterfrom
tlaurion:xx30_vbios_script_fixes
Apr 1, 2022
Merged

Improvements on xx30 vbios scripts#1111
tlaurion merged 1 commit into
linuxboot:masterfrom
tlaurion:xx30_vbios_script_fixes

Conversation

@tlaurion

@tlaurion tlaurion commented Feb 15, 2022

Copy link
Copy Markdown
Collaborator
  • Better error handling (exits earlier)
  • Better scoping of UEFIExtract to only deal with FL1 files, which is where vbios files are to be extracted from.
  • Adds sudo calls where required (CircleCI runs at root. Local builds failed, as reported Error compiling w530-dgpu-K1000m-maximized #1110 (comment)

@eganonoa @MrChromebox : improvements welcome. CircleCI works and extraction is confirmed to build locally as well over debian-11. Consequently, this is considered a bug in original code and should be merged ASAP.

Fixes #1085

…or FL1 files only. Also add sudo calls where required
@tlaurion

Copy link
Copy Markdown
Collaborator Author

Next improvement would probably to not bind the scripts to Debian only and move software dependencies outside.

But as of now, it works and fails where needed.

@MrChromebox please poke me when reviewed. To me its ready to merge

@tlaurion

tlaurion commented Mar 28, 2022

Copy link
Copy Markdown
Collaborator Author

@MrChromebox : ping

Unless you see something stupid, this is improvement as opposed to what is on master.

@tlaurion
tlaurion merged commit dfbb0db into linuxboot:master Apr 1, 2022
tlaurion added a commit to tlaurion/heads that referenced this pull request Sep 10, 2026
Improvements on xx30 vbios scriptsSigned-off-by: Thierry Laurion <insurgo@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vbios scripts lack validation

2 participants