rnull: add configfs, remote completion to rnull by blktests-ci-kpd[bot] · Pull Request #29 · linux-blktests/linux-block

blktests-ci-kpd · 2025-07-10T12:00:25Z

Pull request for series with
subject: rnull: add configfs, remote completion to rnull
version: 2
url: https://patchwork.kernel.org/project/linux-block/list/?series=980177

blktests-ci-kpd · 2025-07-10T12:00:26Z

Upstream branch: 8c2e52e
series: https://patchwork.kernel.org/project/linux-block/list/?series=980177
version: 2

blktests-ci-kpd · 2025-07-10T17:09:00Z

Upstream branch: bc9ff19
series: https://patchwork.kernel.org/project/linux-block/list/?series=980177
version: 2

blktests-ci-kpd · 2025-07-11T01:17:58Z

Upstream branch: bc9ff19
series: https://patchwork.kernel.org/project/linux-block/list/?series=980177
version: 2

blktests-ci-kpd · 2025-07-11T07:10:24Z

Upstream branch: bc9ff19
series: https://patchwork.kernel.org/project/linux-block/list/?series=980177
version: 2

blktests-ci-kpd · 2025-07-11T11:47:38Z

Upstream branch: bc9ff19
series: https://patchwork.kernel.org/project/linux-block/list/?series=981500
version: 3

blktests-ci-kpd · 2025-07-11T17:50:25Z

Upstream branch: 40f92e7
series: https://patchwork.kernel.org/project/linux-block/list/?series=981500
version: 3

Clean up imports in `str.rs`. This makes future code manipulation more manageable. Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Improve `Formatter` so that it can write to an array or slice buffer. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rnull is going to make use of `str::Formatter`, so expose it with public visibility. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rnull is going to make use of `kernel::str::RawFormatter::bytes_written`, so make the visibility public. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Add `NullTerminatedFormatter`, a formatter that writes a null terminated string to an array or slice buffer. Because this type needs to manage the trailing null marker, the existing formatters cannot be used to implement this type. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Clean up the import statements in `gen_disk.rs` to make the code easier to maintain. Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Use the new `NullTerminatedFormatter` to write the name of a `GenDisk` to the name buffer. This new formatter automatically adds a trailing null marker after the written characters, so we don't need to append that at the call site any longer. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

`RawWriter` is now dead code, so remove it. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Remove the trait bound `T:Operations` from `mq::Request`. The bound is not required, so remove it to reduce complexity. Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Add a few block subsystem constants to the rust `kernel::block` name space. This makes it easier to access the constants from rust code. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

The rust null block driver is about to gain some additional modules. Rather than pollute the current directory, move the driver to a subdirectory. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Allow rust null block devices to be configured and instantiated via `configfs`. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Allow users of the rust block device driver API to install private data in the `GenDisk` structure. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Add code block quotes to a safety comment. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Allow users of rust block device driver API to schedule completion of requests via `blk_mq_complete_request_remote`. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

blktests-ci-kpd · 2025-07-11T23:31:27Z

Upstream branch: 40f92e7
series: https://patchwork.kernel.org/project/linux-block/list/?series=981500
version: 3

rnull currently only supports direct completion. Add option for completing requests across CPU nodes via soft IRQ or IPI. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

blktests-ci-kpd · 2025-07-23T02:15:06Z

Upstream branch: 89be9a8
series: https://patchwork.kernel.org/project/linux-block/list/?series=981500
version: 3

blktests-ci-kpd · 2025-07-23T02:28:56Z

Upstream branch: 89be9a8
series: https://patchwork.kernel.org/project/linux-block/list/?series=981500
version: 3

blktests-ci-kpd · 2025-07-24T08:34:14Z

Upstream branch: 25fae0b
series: https://patchwork.kernel.org/project/linux-block/list/?series=981500
version: 3

blktests-ci-kpd · 2025-07-24T08:37:07Z

Github failed to update this PR after force push. Close it.

Without the change `perf `hangs up on charaster devices. On my system it's enough to run system-wide sampler for a few seconds to get the hangup: $ perf record -a -g --call-graph=dwarf $ perf report # hung `strace` shows that hangup happens on reading on a character device `/dev/dri/renderD128` $ strace -y -f -p 2780484 strace: Process 2780484 attached pread64(101</dev/dri/renderD128>, strace: Process 2780484 detached It's call trace descends into `elfutils`: $ gdb -p 2780484 (gdb) bt #0 0x00007f5e508f04b7 in __libc_pread64 (fd=101, buf=0x7fff9df7edb0, count=0, offset=0) at ../sysdeps/unix/sysv/linux/pread64.c:25 #1 0x00007f5e52b79515 in read_file () from /<<NIX>>/elfutils-0.192/lib/libelf.so.1 #2 0x00007f5e52b25666 in libdw_open_elf () from /<<NIX>>/elfutils-0.192/lib/libdw.so.1 #3 0x00007f5e52b25907 in __libdw_open_file () from /<<NIX>>/elfutils-0.192/lib/libdw.so.1 #4 0x00007f5e52b120a9 in dwfl_report_elf@@ELFUTILS_0.156 () from /<<NIX>>/elfutils-0.192/lib/libdw.so.1 #5 0x000000000068bf20 in __report_module (al=al@entry=0x7fff9df80010, ip=ip@entry=139803237033216, ui=ui@entry=0x5369b5e0) at util/dso.h:537 #6 0x000000000068c3d1 in report_module (ip=139803237033216, ui=0x5369b5e0) at util/unwind-libdw.c:114 #7 frame_callback (state=0x535aef10, arg=0x5369b5e0) at util/unwind-libdw.c:242 #8 0x00007f5e52b261d3 in dwfl_thread_getframes () from /<<NIX>>/elfutils-0.192/lib/libdw.so.1 #9 0x00007f5e52b25bdb in get_one_thread_cb () from /<<NIX>>/elfutils-0.192/lib/libdw.so.1 #10 0x00007f5e52b25faa in dwfl_getthreads () from /<<NIX>>/elfutils-0.192/lib/libdw.so.1 #11 0x00007f5e52b26514 in dwfl_getthread_frames () from /<<NIX>>/elfutils-0.192/lib/libdw.so.1 #12 0x000000000068c6ce in unwind__get_entries (cb=cb@entry=0x5d4620 <unwind_entry>, arg=arg@entry=0x10cd5fa0, thread=thread@entry=0x1076a290, data=data@entry=0x7fff9df80540, max_stack=max_stack@entry=127, best_effort=best_effort@entry=false) at util/thread.h:152 #13 0x00000000005dae95 in thread__resolve_callchain_unwind (evsel=0x106006d0, thread=0x1076a290, cursor=0x10cd5fa0, sample=0x7fff9df80540, max_stack=127, symbols=true) at util/machine.c:2939 #14 thread__resolve_callchain_unwind (thread=0x1076a290, cursor=0x10cd5fa0, evsel=0x106006d0, sample=0x7fff9df80540, max_stack=127, symbols=true) at util/machine.c:2920 #15 __thread__resolve_callchain (thread=0x1076a290, cursor=0x10cd5fa0, evsel=0x106006d0, evsel@entry=0x7fff9df80440, sample=0x7fff9df80540, parent=parent@entry=0x7fff9df804a0, root_al=root_al@entry=0x7fff9df80440, max_stack=127, symbols=true) at util/machine.c:2970 #16 0x00000000005d0cb2 in thread__resolve_callchain (thread=<optimized out>, cursor=<optimized out>, evsel=0x7fff9df80440, sample=<optimized out>, parent=0x7fff9df804a0, root_al=0x7fff9df80440, max_stack=127) at util/machine.h:198 #17 sample__resolve_callchain (sample=<optimized out>, cursor=<optimized out>, parent=parent@entry=0x7fff9df804a0, evsel=evsel@entry=0x106006d0, al=al@entry=0x7fff9df80440, max_stack=max_stack@entry=127) at util/callchain.c:1127 #18 0x0000000000617e08 in hist_entry_iter__add (iter=iter@entry=0x7fff9df80480, al=al@entry=0x7fff9df80440, max_stack_depth=127, arg=arg@entry=0x7fff9df81ae0) at util/hist.c:1255 #19 0x000000000045d2d0 in process_sample_event (tool=0x7fff9df81ae0, event=<optimized out>, sample=0x7fff9df80540, evsel=0x106006d0, machine=<optimized out>) at builtin-report.c:334 #20 0x00000000005e3bb1 in perf_session__deliver_event (session=0x105ff2c0, event=0x7f5c7d735ca0, tool=0x7fff9df81ae0, file_offset=2914716832, file_path=0x105ffbf0 "perf.data") at util/session.c:1367 #21 0x00000000005e8d93 in do_flush (oe=0x105ffa50, show_progress=false) at util/ordered-events.c:245 #22 __ordered_events__flush (oe=0x105ffa50, how=OE_FLUSH__ROUND, timestamp=<optimized out>) at util/ordered-events.c:324 #23 0x00000000005e1f64 in perf_session__process_user_event (session=0x105ff2c0, event=0x7f5c7d752b18, file_offset=2914835224, file_path=0x105ffbf0 "perf.data") at util/session.c:1419 #24 0x00000000005e47c7 in reader__read_event (rd=rd@entry=0x7fff9df81260, session=session@entry=0x105ff2c0, --Type <RET> for more, q to quit, c to continue without paging-- quit prog=prog@entry=0x7fff9df81220) at util/session.c:2132 #25 0x00000000005e4b37 in reader__process_events (rd=0x7fff9df81260, session=0x105ff2c0, prog=0x7fff9df81220) at util/session.c:2181 #26 __perf_session__process_events (session=0x105ff2c0) at util/session.c:2226 #27 perf_session__process_events (session=session@entry=0x105ff2c0) at util/session.c:2390 #28 0x0000000000460add in __cmd_report (rep=0x7fff9df81ae0) at builtin-report.c:1076 #29 cmd_report (argc=<optimized out>, argv=<optimized out>) at builtin-report.c:1827 #30 0x00000000004c5a40 in run_builtin (p=p@entry=0xd8f7f8 <commands+312>, argc=argc@entry=1, argv=argv@entry=0x7fff9df844b0) at perf.c:351 #31 0x00000000004c5d63 in handle_internal_command (argc=argc@entry=1, argv=argv@entry=0x7fff9df844b0) at perf.c:404 #32 0x0000000000442de3 in run_argv (argcp=<synthetic pointer>, argv=<synthetic pointer>) at perf.c:448 #33 main (argc=<optimized out>, argv=0x7fff9df844b0) at perf.c:556 The hangup happens because nothing in` perf` or `elfutils` checks if a mapped file is easily readable. The change conservatively skips all non-regular files. Signed-off-by: Sergei Trofimovich <slyich@gmail.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Link: https://lore.kernel.org/r/20250505174419.2814857-1-slyich@gmail.com Signed-off-by: Namhyung Kim <namhyung@kernel.org>

When running on a setup affected with broken CNTVOFF_EL2 (has_broken_cntvoff()) Booting with VHE or protected mode(nvhe) (id_aa64mmfr1.vh=0 and arm64_sw.hvhe=0) works fine. However launching a protected VM with protected hvhe mode panics the guest kernel: [ 0.000000] Internal error: Oops - Undefined instruction: 0000000000000000 [#1] SMP [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 7.2.0-rc3-g05f75bd71e0e-dirty #29 PREEMPT [ 0.000000] Hardware name: linux,dummy-virt (DT) [ 0.000000] pstate: 000003c5 (nzcv DAIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 0.000000] pc : arch_timer_shutdown_virt+0x4/0x1c [ 0.000000] lr : arch_timer_starting_cpu+0x1c4/0x2d4 [ 0.000000] sp : ffffa6bd9a193c00 [ 0.000000] x29: ffffa6bd9a193c20 x28: ffffa6bd9a1bcf88 x27: 0000000000000000 [ 0.000000] x26: ffff00001be70dd8 x25: ffffa6bd99d85000 x24: ffffa6bd99d85ee4 [ 0.000000] x23: ffffa6bd99d85000 x22: ffffa6bd9a1499c0 x21: ffffa6bd9a1ab900 [ 0.000000] x20: 00ffffffffffffff x19: ffff00001be8b600 x18: 000000000000028c [ 0.000000] x17: 00000000510f0010 x16: 00000000510f0010 x15: 00000000500f0000 [ 0.000000] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000018 [ 0.000000] x11: ffffa6bd9a8ac000 x10: 0000000000f0000f x9 : ffffffffffffffff [ 0.000000] x8 : ffffa6bd98822e18 x7 : 0070752d65746174 x6 : 00111ff76e007261 [ 0.000000] x5 : ffffa6bd9ad68078 x4 : 0000000000000000 x3 : ffffa6bd98822a0c [ 0.000000] x2 : 0000000000000073 x1 : 0000000000000001 x0 : ffff00001be8b600 [ 0.000000] Call trace: [ 0.000000] arch_timer_shutdown_virt+0x4/0x1c (P) [ 0.000000] cpuhp_invoke_callback+0x11c/0x280 [ 0.000000] cpuhp_issue_call+0x1e8/0x224 [ 0.000000] __cpuhp_setup_state_cpuslocked+0x1d8/0x2b8 [ 0.000000] __cpuhp_setup_state+0x50/0x74 [ 0.000000] arch_timer_register+0xc0/0x148 [ 0.000000] arch_timer_of_init+0x148/0x170 [ 0.000000] timer_probe+0x74/0x124 [ 0.000000] time_init+0x18/0x58 [ 0.000000] start_kernel+0x1c0/0x3ac [ 0.000000] __primary_switched+0x88/0x90 [ 0.000000] Code: c80b7d2a 35ffffab 17ffffeb d503245f (d53be328) The workaround avoids setting non-zero CNTVOFF_EL2 and trapping the virtual counter to emulate the offset. In the VHE path (timer_set_traps()), traps are only enabled when the guest actually has a non-zero virtual timer offset. However, __timer_enable_traps() in hyp/nvhe/timer-sr.c unconditionally set CNTHCTL_EL1TVT and CNTHCTL_EL1TVCT whenever has_broken_cntvoff() was true. Which causes 2 issues: 1) Protected VMs: kvm_handle_pvm_sysreg() does not find "cntv_ctl_el0" in pvm_sys_reg_descs and injects undefined instruction exceptions. 2) non-protected guests are trapped all the time even with offset of zero. Fix this by adding a check in __timer_enable_traps() similar to the one in timer_set_traps() Fixes: 0bc9a9e ("KVM: arm64: Work around x1e's CNTVOFF_EL2 bogosity") Reviewed-by: Yuan Yao <yaoyuan@linux.alibaba.com> Reviewed-by: Fuad Tabba <fuad.tabba@linux.dev> Tested-by: Fuad Tabba <fuad.tabba@linux.dev> Signed-off-by: Mostafa Saleh <smostafa@google.com> Link: https://patch.msgid.link/20260808085824.732659-4-smostafa@google.com Signed-off-by: Oliver Upton <oupton@kernel.org>

blktests-ci-kpd Bot added new V2 linus-master labels Jul 10, 2025

blktests-ci-kpd Bot force-pushed the linus-master_base branch from ac8b12e to 9a69d4f Compare July 10, 2025 17:03

blktests-ci-kpd Bot force-pushed the series/972520=>linus-master branch from 2a671ae to 27f4f35 Compare July 10, 2025 17:09

blktests-ci-kpd Bot force-pushed the linus-master_base branch from 9a69d4f to e311dd9 Compare July 11, 2025 01:13

blktests-ci-kpd Bot force-pushed the series/972520=>linus-master branch from 27f4f35 to f3fd976 Compare July 11, 2025 01:18

blktests-ci-kpd Bot force-pushed the linus-master_base branch from e311dd9 to b6b569e Compare July 11, 2025 07:05

blktests-ci-kpd Bot force-pushed the series/972520=>linus-master branch from f3fd976 to c412d58 Compare July 11, 2025 07:10

blktests-ci-kpd Bot added V3 and removed V2 labels Jul 11, 2025

blktests-ci-kpd Bot force-pushed the series/972520=>linus-master branch from c412d58 to afee38c Compare July 11, 2025 11:47

blktests-ci-kpd Bot force-pushed the linus-master_base branch from b6b569e to ef2c9cd Compare July 11, 2025 17:45

blktests-ci-kpd Bot force-pushed the series/972520=>linus-master branch from afee38c to 71b9b0f Compare July 11, 2025 17:50

adding ci files

198825c

blktests-ci-kpd Bot force-pushed the linus-master_base branch from ef2c9cd to 198825c Compare July 11, 2025 23:25

Andreas Hindborg added 8 commits July 12, 2025 08:31

rust: str: normalize imports in str.rs

8ad3d4e

Clean up imports in `str.rs`. This makes future code manipulation more manageable. Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rust: str: allow str::Formatter to format into &mut [u8].

0c10321

Improve `Formatter` so that it can write to an array or slice buffer. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rust: str: expose str::Formatter::new publicly.

56ab816

rnull is going to make use of `str::Formatter`, so expose it with public visibility. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rust: str: make RawFormatter::bytes_written public.

e3b9ab6

rnull is going to make use of `kernel::str::RawFormatter::bytes_written`, so make the visibility public. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rust: block: normalize imports for gen_disk.rs

ccd31b7

Clean up the import statements in `gen_disk.rs` to make the code easier to maintain. Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rust: block: remove RawWriter

4106c53

`RawWriter` is now dead code, so remove it. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

Andreas Hindborg added 7 commits July 12, 2025 08:31

rust: block: remove trait bound from mq::Request definition

2290eff

Remove the trait bound `T:Operations` from `mq::Request`. The bound is not required, so remove it to reduce complexity. Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rust: block: add block related constants

65cbe86

Add a few block subsystem constants to the rust `kernel::block` name space. This makes it easier to access the constants from rust code. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rnull: move driver to separate directory

a3d708a

The rust null block driver is about to gain some additional modules. Rather than pollute the current directory, move the driver to a subdirectory. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rnull: enable configuration via configfs

83290a4

Allow rust null block devices to be configured and instantiated via `configfs`. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rust: block: add GenDisk private data support

19dc900

Allow users of the rust block device driver API to install private data in the `GenDisk` structure. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rust: block: mq: fix spelling in a safety comment

6eacb80

Add code block quotes to a safety comment. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rust: block: add remote completion to Request

5927130

Allow users of rust block device driver API to schedule completion of requests via `blk_mq_complete_request_remote`. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

rnull: add soft-irq completion support

36cb61f

rnull currently only supports direct completion. Add option for completing requests across CPU nodes via soft IRQ or IPI. Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>

blktests-ci-kpd Bot force-pushed the series/972520=>linus-master branch from 71b9b0f to 36cb61f Compare July 11, 2025 23:31

blktests-ci-kpd Bot force-pushed the linus-master_base branch from 198825c to 341e7ed Compare July 14, 2025 02:27

blktests-ci-kpd Bot force-pushed the linus-master_base branch from 341e7ed to 81f31a4 Compare July 23, 2025 02:05

blktests-ci-kpd Bot force-pushed the linus-master_base branch from 81f31a4 to 87bbbbc Compare July 24, 2025 05:40

blktests-ci-kpd Bot closed this Jul 24, 2025

blktests-ci-kpd Bot deleted the series/972520=>linus-master branch July 31, 2025 04:38

Navigation Menu

Repository navigation

rnull: add configfs, remote completion to rnull - #29

rnull: add configfs, remote completion to rnull#29
blktests-ci-kpd[bot] wants to merge 17 commits into
linus-master_basefrom
series/972520=>linus-master

blktests-ci-kpd Bot commented Jul 10, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 10, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 10, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 23, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 23, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 24, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

blktests-ci-kpd Bot commented Jul 10, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 10, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 10, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 11, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 23, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 23, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 24, 2025

Uh oh!

blktests-ci-kpd Bot commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant