Repository navigation
blktrace: build the synthesized v1 record from the entry's own layout - #1301
Open
blktests-ci-kpd[bot] wants to merge 1 commit into
Open
blktests-ci-kpd[bot] wants to merge 1 commit into
blktests-ci-kpd[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 5225b8e |
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 13, 2026 08:50
a0aeca9 to
772381e
Compare
Author
|
Upstream branch: 2f0c1cf |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
September 13, 2026 09:40
048a150 to
6f5497b
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 13, 2026 22:56
772381e to
0224dee
Compare
Author
|
Upstream branch: 2f0c1cf |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
September 13, 2026 22:59
6f5497b to
76a4234
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 15, 2026 09:28
0224dee to
f14340f
Compare
Author
|
Upstream branch: 5878583 |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
September 15, 2026 09:33
76a4234 to
7956c0e
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 17, 2026 19:27
f14340f to
0e174bc
Compare
Author
|
Upstream branch: 4982d35 |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
September 17, 2026 19:31
7956c0e to
ebcfd76
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 18, 2026 13:22
0e174bc to
fbef20f
Compare
Author
|
Upstream branch: 5dd1818 |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
September 18, 2026 13:26
ebcfd76 to
987743e
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 20, 2026 20:45
fbef20f to
4a650fc
Compare
Author
|
Upstream branch: 6a5719c |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
September 20, 2026 20:48
987743e to
22dce9c
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 22, 2026 14:09
4a650fc to
c65e2dc
Compare
Author
|
Upstream branch: f010036 |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
September 22, 2026 14:37
22dce9c to
c995118
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 28, 2026 14:39
372fcdc to
c6537fe
Compare
Author
|
Upstream branch: 72d3fcf |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
September 28, 2026 15:18
75fc35d to
4a62fec
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 1, 2026 15:18
c6537fe to
eebb5bc
Compare
Author
|
Upstream branch: 551c722 |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
October 1, 2026 16:09
4a62fec to
8557bf4
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 1, 2026 23:18
eebb5bc to
bbd3af0
Compare
Author
|
Upstream branch: ce1e022 |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
October 1, 2026 23:48
8557bf4 to
5443f36
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 3, 2026 09:37
bbd3af0 to
a9c0b46
Compare
Author
|
Upstream branch: e767a4e |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
October 3, 2026 10:12
5443f36 to
50be900
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 3, 2026 21:50
a9c0b46 to
72d0f5e
Compare
Author
|
Upstream branch: a74306e |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
October 3, 2026 22:21
50be900 to
01a0b4f
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 5, 2026 02:03
72d0f5e to
d980ad5
Compare
Author
|
Upstream branch: None |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
October 5, 2026 02:28
01a0b4f to
83d4f06
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 6, 2026 12:35
d980ad5 to
83b99cc
Compare
Author
|
Upstream branch: 22430ae |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
October 6, 2026 13:12
83d4f06 to
08998dd
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 6, 2026 16:58
83b99cc to
9081535
Compare
Author
|
Upstream branch: 69f80fe |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
October 6, 2026 17:26
08998dd to
410956c
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 7, 2026 15:18
9081535 to
6118c5c
Compare
blk_trace_synthesize_old_trace() emits a classic blk_io_trace for the binary trace_pipe output by copying 32 bytes from the ring buffer entry's sector onward into a struct blk_io_trace. It reads them at blk_io_trace2 offsets, and the two layouts diverge after bytes: v2 has a 32-bit pid at 28 and a 64-bit action at 32, where v1 has a 32-bit action at 28 and pid at 32. On a v2 entry every field from action on lands one slot off, so a consumer reads the pid as the action, the device as the cpu, and the cpu as error and pdu_len. The PDU comes from the wrong offset as well. The copy ends at v2 offset 48 + pdu_len while the PDU starts at 64, and the emitted pdu_len is taken from the v2 cpu, so it reads 0 while extra bytes were appended and the consumer resynchronizes on the wrong boundary. The entry is not always a v2 record. __blk_add_trace() reserves sizeof(struct blk_io_trace) when the trace was set up by BLKTRACESETUP, and on such an entry the 32-byte copy is correct. pdu_len is still read at v2 offset 50 though, past the end of a 48-byte entry, and drives an unbounded copy that desynchronizes the stream. That is what syzbot hit. Take the layout from iter->ent_size, which is the only discriminator the entry carries -- magic and sequence are the ftrace header, not a version stamp. Assign the v1 fields from their counterparts in that layout and append the PDU from the end of it, bounded by the entry size. BUG: KASAN: slab-out-of-bounds in seq_buf_putmem+0x124/0x180 Read of size 1352 at addr ffff8880295bdb98 by task syz.2.2551/19243 seq_buf_putmem+0x124/0x180 lib/seq_buf.c:241 blk_trace_synthesize_old_trace kernel/trace/blktrace.c:1780 [inline] blk_trace_event_print_binary+0x130/0x1b0 kernel/trace/blktrace.c:1788 tracing_read_pipe+0x568/0xb50 kernel/trace/trace.c:5444 vfs_read+0x213/0xa80 fs/read_write.c:572 Fixes: 4d8bc7b ("blktrace: move ftrace blk_io_tracer to blk_io_trace2") Reported-by: syzbot+f179b16e13624138b0f1@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=f179b16e13624138b0f1 Cc: stable@vger.kernel.org Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com> Assisted-by: Claude:claude-fable-5
Author
|
Upstream branch: 7b63ef2 |
blktests-ci-kpd
Bot
force-pushed
the
series/1163668=>linus-master
branch
from
October 7, 2026 15:53
410956c to
f9a7538
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: blktrace: build the synthesized v1 record from the entry's own layout
version: 1
url: https://patchwork.kernel.org/series/1163668/