Repository navigation
virtio_blk: use synchronous quiesce in virtblk_freeze_priv() - #1286
Open
blktests-ci-kpd[bot] wants to merge 1 commit into
Open
blktests-ci-kpd[bot] wants to merge 1 commit into
blktests-ci-kpd[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 50d05c7 |
Author
|
Upstream branch: 50d05c7 |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
September 11, 2026 02:36
bd2df17 to
72e4775
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 12, 2026 02:26
7efd8cd to
a0aeca9
Compare
Author
|
Upstream branch: 5225b8e |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
September 12, 2026 02:40
72e4775 to
3cc6c21
Compare
Author
|
Upstream branch: 5225b8e |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
September 12, 2026 09:11
3cc6c21 to
3591f20
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 13, 2026 08:50
a0aeca9 to
772381e
Compare
Author
|
Upstream branch: 2f0c1cf |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
September 13, 2026 09:42
3591f20 to
b7ddbb9
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 13, 2026 22:56
772381e to
0224dee
Compare
Author
|
Upstream branch: 2f0c1cf |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
September 13, 2026 23:01
b7ddbb9 to
b102a54
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 15, 2026 09:28
0224dee to
f14340f
Compare
Author
|
Upstream branch: 5878583 |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
September 15, 2026 09:35
b102a54 to
cf27a35
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 17, 2026 19:27
f14340f to
0e174bc
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 1, 2026 15:18
c6537fe to
eebb5bc
Compare
Author
|
Upstream branch: 551c722 |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
October 1, 2026 15:24
538cc63 to
2c3d876
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 1, 2026 23:18
eebb5bc to
bbd3af0
Compare
Author
|
Upstream branch: ce1e022 |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
October 1, 2026 23:23
2c3d876 to
2518147
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 3, 2026 09:37
bbd3af0 to
a9c0b46
Compare
Author
|
Upstream branch: e767a4e |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
October 3, 2026 09:40
2518147 to
5cbbe68
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 3, 2026 21:50
a9c0b46 to
72d0f5e
Compare
Author
|
Upstream branch: a74306e |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
October 3, 2026 22:01
5cbbe68 to
34cdc8d
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 5, 2026 02:03
72d0f5e to
d980ad5
Compare
Author
|
Upstream branch: None |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
October 5, 2026 02:08
34cdc8d to
dd6ddf6
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 6, 2026 12:35
d980ad5 to
83b99cc
Compare
Author
|
Upstream branch: 22430ae |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
October 6, 2026 13:16
dd6ddf6 to
0e201a3
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 6, 2026 16:58
83b99cc to
9081535
Compare
Author
|
Upstream branch: 69f80fe |
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
October 6, 2026 17:29
0e201a3 to
6a6c6c1
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 7, 2026 15:18
9081535 to
6118c5c
Compare
Author
|
Upstream branch: 7b63ef2 |
blk_mq_run_work_fn() can call blk_mq_sched_dispatch_requests() through blk_mq_run_dispatch_ops(). The dispatcher checks QUEUE_FLAG_QUIESCED while the flag is clear. It can then be preempted before it gets a request. At that time, it has no queue usage reference, so blk_mq_freeze_queue() does not wait for it. virtblk_freeze_priv() then calls blk_mq_quiesce_queue_nowait() and blk_mq_unfreeze_queue(). A new request can enter the queue. The old dispatcher can run again, use its old flag check, get the new request, and call virtio_queue_rq(). At the same time, virtblk_freeze_priv() can reset the device, delete the virtqueues, and free vblk->vqs. The old dispatcher can then use a deleted virtqueue or a NULL vblk->vqs, and the kernel can crash. Fix this by using blk_mq_quiesce_queue(), which waits for dispatch code that was already running. Keep the existing freeze and unfreeze order. The queue remains quiesced until virtblk_restore_priv() calls blk_mq_unquiesce_queue(). Fixes: 7678abe ("virtio-blk: don't keep queue frozen during system suspend") Cc: stable@vger.kernel.org Acked-by: Jason Wang <jasowangio@gmail.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Cong Zhang <cong.zhang@oss.qualcomm.com>
blktests-ci-kpd
Bot
force-pushed
the
series/1162215=>linus-master
branch
from
October 7, 2026 16:16
6a6c6c1 to
567aeff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: virtio_blk: use synchronous quiesce in virtblk_freeze_priv()
version: 1
url: https://patchwork.kernel.org/series/1162215/