Repository navigation
block, nfsd: fixes for sub-sector bvec direct I/O - #1272
Closed
blktests-ci-kpd[bot] wants to merge 1 commit into
Closed
blktests-ci-kpd[bot] wants to merge 1 commit into
blktests-ci-kpd[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 28924df |
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 9, 2026 07:40
4ddd216 to
00cc4ca
Compare
Author
|
Upstream branch: 893e117 |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
September 9, 2026 08:01
f4d8902 to
8013db8
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 10, 2026 15:29
00cc4ca to
7efd8cd
Compare
Author
|
Upstream branch: 50d05c7 |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
September 10, 2026 15:43
8013db8 to
096d4de
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 12, 2026 02:26
7efd8cd to
a0aeca9
Compare
Author
|
Upstream branch: 5225b8e |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
September 12, 2026 02:38
096d4de to
6cb2bc5
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 13, 2026 08:50
a0aeca9 to
772381e
Compare
Author
|
Upstream branch: 2f0c1cf |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
September 13, 2026 10:07
6cb2bc5 to
9659271
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 13, 2026 22:56
772381e to
0224dee
Compare
Author
|
Upstream branch: 2f0c1cf |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
September 13, 2026 23:09
9659271 to
79c5eae
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 15, 2026 09:28
0224dee to
f14340f
Compare
Author
|
Upstream branch: 5878583 |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
September 15, 2026 09:43
79c5eae to
f8453da
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 17, 2026 19:27
f14340f to
0e174bc
Compare
Author
|
Upstream branch: 4982d35 |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
September 17, 2026 19:54
f8453da to
6c9a7ea
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 18, 2026 13:22
0e174bc to
fbef20f
Compare
Author
|
Upstream branch: 5dd1818 |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
September 18, 2026 13:43
6c9a7ea to
899bbab
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
September 20, 2026 20:45
fbef20f to
4a650fc
Compare
Author
|
Upstream branch: 72d3fcf |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
September 28, 2026 15:24
0967633 to
34450ca
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 1, 2026 15:18
c6537fe to
eebb5bc
Compare
Author
|
Upstream branch: 551c722 |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
October 1, 2026 16:17
34450ca to
5218bde
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 1, 2026 23:18
eebb5bc to
bbd3af0
Compare
Author
|
Upstream branch: ce1e022 |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
October 1, 2026 23:55
5218bde to
960638f
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 3, 2026 09:37
bbd3af0 to
a9c0b46
Compare
Author
|
Upstream branch: e767a4e |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
October 3, 2026 10:18
960638f to
5aaded0
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 3, 2026 21:50
a9c0b46 to
72d0f5e
Compare
Author
|
Upstream branch: a74306e |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
October 3, 2026 22:27
5aaded0 to
26d3808
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 5, 2026 02:03
72d0f5e to
d980ad5
Compare
Author
|
Upstream branch: None |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
October 5, 2026 02:34
26d3808 to
aefaac0
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 6, 2026 12:35
d980ad5 to
83b99cc
Compare
Author
|
Upstream branch: 22430ae |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
October 6, 2026 13:18
aefaac0 to
36093b4
Compare
blktests-ci-kpd
Bot
force-pushed
the
linus-master_base
branch
from
October 6, 2026 16:58
83b99cc to
9081535
Compare
Author
|
Upstream branch: 69f80fe |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
October 6, 2026 17:32
36093b4 to
347900b
Compare
brd_rw_bvec() takes the device position from bio->bi_iter.bi_sector, which bio_advance_iter_single() advances by bytes >> SECTOR_SHIFT. For a bvec whose length is not a multiple of the sector size the sector cursor silently loses the sub-sector residue while the data cursor (bi_bvec_done/bi_size) consumes the full length -- from that segment on, data is written at a device offset short of where it belongs, and every subsequent byte lands shifted with no error reported anywhere. Such bvec geometry is legal at the submitter: ITER_BVEC direct I/O passes the caller's bio_vec array through as-is (bio_iov_bvec_set()), so e.g. NFSD's NFSD_IO_DIRECT write path hands XFS/iomap a payload whose first fragment starts mid-page (the RPC header precedes it in the receive buffer) and whose fragment lengths are not sector multiples. A 1 MiB write arriving as bv0=(160,16224) + 63x(0,16384) + (0,160) reproduces on brd as: first 15872 = ALIGN_DOWN(16224, 512) bytes correct, everything after shifted forward by 352 = 16224 - 15872 bytes -- while the write completes successfully. Any NFSD_IO_DIRECT (or other kernel bvec direct I/O) write to a brd-backed filesystem is exposed; request-based drivers are unaffected because nothing in the request path does per-bvec sector arithmetic. Track the device position as a byte offset owned by the submit loop and advanced by the number of bytes each segment actually processed, instead of re-deriving it from the skewed bi_sector. Verified with a synthetic-bio reproducer over brd directly and through nvme-loop: mid-page-offset geometries and the page-aligned control now all read back byte-identical, and 20 fresh NFS connections x 16 MiB of O_DIRECT writes over an XFS-on-nvme-loop-on-brd export complete with zero data mismatches (previously most connections corrupted). Fixes: 3185444 ("brd: split I/O at page boundaries") Assisted-by: Claude:claude-fable-5 Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Author
|
Upstream branch: 7b63ef2 |
blktests-ci-kpd
Bot
force-pushed
the
series/1160666=>linus-master
branch
from
October 7, 2026 16:19
347900b to
87c6ebf
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/series/1160666/ irrelevant now for [{'archived': False, 'project': 241}] search patterns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: block, nfsd: fixes for sub-sector bvec direct I/O
version: 1
url: https://patchwork.kernel.org/series/1160666/