Repository navigation
Fix gemma3 monkey patch tests - #735
Merged
Merged
Conversation
lancerts
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With transformers >= 4.52.0, there was some refactoring of gemma3 model code. Patching should still work for previous transformers version, but gemma3 tests won't pass for older transformers versions. Not sure we want to maintain that logic in the tests.
For reference:
Fixing part of #729
Testing Done
Gemma3 monkey patch tests pass
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence