refactor(banners): drop the CTA host allowlist - #4924
Merged
Merged
Conversation
Banner commands are already authenticated by broker credentials and bindings, so the per-context cta_hosts list added configuration without adding meaningful protection. Commands are now accepted or skipped on their category alone. CTA URLs must still be absolute https URLs of at most 2048 bytes.
rezk2ll
approved these changes
Sep 15, 2026
shepilov
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Banner commands are already authenticated by broker credentials and bindings, so the per-context
banner.cta_hostslist is removed along with its check. Commands are now accepted or skipped on their category alone.CTA URLs are still validated: absolute
https, at most 2048 bytes.docs/banners.mdandcozy.example.yamlare updated accordingly.