Use packaging.version instead of pkg_resources.parse_version by default#180
Closed
felixonmars wants to merge 1 commit intolilydjwg:masterfrom
Closed
Use packaging.version instead of pkg_resources.parse_version by default#180felixonmars wants to merge 1 commit intolilydjwg:masterfrom
felixonmars wants to merge 1 commit intolilydjwg:masterfrom
Conversation
packaging.version is the new standard and should be preferred now. It reduces startup time significantly too as pkg_resources is expensive to import. parse_version is only kept for compatibility here, perhaps consider removing it in the future.
Contributor
Author
|
The test failures are irrelevant. |
Owner
|
The issue with We may need to implement a loose version comparison algorithm ourselves. |
Contributor
|
Test failures are addressed in #181 |
Contributor
Author
pkg_resources.parse_version uses the same code here, IIRC. (The LegacyVersion warning is also present in current test implementation.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packaging.version is the new standard and should be preferred now. It
reduces startup time significantly too as pkg_resources is expensive to
import.
parse_version is only kept for compatibility here, perhaps consider
removing it in the future.