4354 follow up#4407
Merged
valentinewallace merged 3 commits intolightningdevkit:mainfrom Feb 10, 2026
Merged
Conversation
test_default_channel_config is the default now so it does not need to be set explicitly in some of the tests. Removes unnecessary extra None config.
|
👋 I see @tankyleo was un-assigned. |
tankyleo
requested review from
valentinewallace
and removed request for
tankyleo
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4407 +/- ##
=======================================
Coverage 86.05% 86.06%
=======================================
Files 156 156
Lines 103188 103188
Branches 103188 103188
=======================================
+ Hits 88799 88808 +9
+ Misses 11878 11868 -10
- Partials 2511 2512 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valentinewallace
approved these changes
Feb 10, 2026
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Contributor
|
CI failures look unrelated, landing |
valentinewallace
merged commit caf0aac
into
lightningdevkit:main
17 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses follow-ups from #4354 (review)