Trivial #3246 followups.#3959
Merged
TheBlueMatt merged 2 commits intolightningdevkit:mainfrom Jul 25, 2025
Merged
Conversation
|
👋 I see @tankyleo was un-assigned. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3959 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02%
==========================================
Files 173 173
Lines 123794 123794
Branches 123794 123794
==========================================
- Hits 110114 110094 -20
- Misses 11227 11242 +15
- Partials 2453 2458 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jkczyz
reviewed
Jul 24, 2025
TheBlueMatt
force-pushed
the
2025-07-3246-followups
branch
from
974ffeb to
1f4d837
Compare
Collaborator
Author
|
Oops, fixed, no changes just comit reordering. |
Instead of making vague reference to "those docs", indicate exactly which docs we're suggesting the user go hunt for. Also, for variant methods, just say "see the original method for more details" rather than trying to spell out all the things that exist in the documentation for the other method. This avoids things getting stale and doesn't reduce the information users have.
TheBlueMatt
force-pushed
the
2025-07-3246-followups
branch
from
1f4d837 to
86c186a
Compare
Collaborator
Author
|
oops bad rebase sorry, fixed. |
jkczyz
approved these changes
Jul 25, 2025
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
CI failure looks like test flakiness
Collaborator
Author
|
Yea, I'm not quite sure what those issues are. Some DNS issue (though DNS lookups tested manually on the server complete ~instantly)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.