Skip to content

test(history): corrupt the index the health query plan actually reads #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 1 commit into from
Oct 30, 2026
Merged

test(history): corrupt the index the health query plan actually reads #7995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions tests/usage/request-history-integrity.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ async function verifyInitial(checks: Check[]): Promise<void> {
await ready;
}

function corruptModelIndex(handle: Database, path: string): void {
const { rootpage } = handle.query("SELECT rootpage FROM sqlite_master WHERE name = 'idx_requests_model'").get() as { rootpage: number };
function corruptModelIndex(handle: Database, path: string, index = "idx_requests_model"): void {
const { rootpage } = handle.query("SELECT rootpage FROM sqlite_master WHERE name = ?").get(index) as { rootpage: number };
const { page_size: pageSize } = handle.query("PRAGMA page_size").get() as { page_size: number };
expect(rootpage).toBeGreaterThan(1);
const checkpoint = handle.query("PRAGMA wal_checkpoint(TRUNCATE)").get() as { busy: number };
Expand All @@ -121,6 +121,22 @@ function corruptModelIndex(handle: Database, path: string): void {
handle.exec("PRAGMA shrink_memory");
}

// Several indexes can serve the health query; which one SQLite's planner picks differs between
// builds (Bun bundles SQLite on Linux and Windows, macOS uses the system library). Corrupt the one
// this build actually reads instead of assuming the model index.
function healthQueryIndex(handle: Database): string {
// prepare + finalize: a query() statement stays cached on the handle and holds a table lock.
const statement = handle.prepare(
"EXPLAIN QUERY PLAN SELECT status FROM requests WHERE provider = ? AND model = ? AND timestamp >= ? ORDER BY timestamp DESC LIMIT ?",
);
let plan: Array<{ detail: string }>;
try { plan = statement.all("a", "m1", 0, 1) as Array<{ detail: string }>; }
finally { statement.finalize(); }
const index = plan.map(row => /USING (?:COVERING )?INDEX (\w+)/.exec(row.detail)?.[1]).find(Boolean);
expect(index).toMatch(/^idx_requests_/);
return index!;
}

describe("request-history integrity lifecycle (#7966)", () => {
test("real worker checks leave repeated page, row, status and routing reads free of full serving-thread scans", async () => {
await existingIndex();
Expand Down Expand Up @@ -409,7 +425,7 @@ describe("request-history integrity lifecycle (#7966)", () => {
clearHealthHistoryCacheForTests();
const handle = requestHistoryDb();
const canonical = readFileSync(usageLogPath());
corruptModelIndex(handle, path);
corruptModelIndex(handle, path, healthQueryIndex(handle));
expect(healthEvidenceForCandidate(input)).toEqual({});
expect((await openRequestHistoryIndex()).indexedRows).toBe(5);
expect(requestHistoryDb()).not.toBe(handle);
Expand Down
Loading