Repository navigation
fix(claude): keep the NO_PROXY receipt across a failed removal, and doc follow-ups (#6936) - #6952
Merged
Merged
Conversation
added 2 commits
October 11, 2026 06:55
Review follow-ups on #6938: - A removal whose settings write fails has not ended the ownership episode, so it now puts the receipt back before rethrowing; a later removal can still restore the user's NO_PROXY. - The proxy's 405 body labels 0.0.0.0 as an unspecified host rather than loopback. - structure/runtime.md states that restoration needs the receipt, and what happens when it could not be written. - The seven translated Claude Code guides now carry the loopback NO_PROXY guidance from the English guide. Refs #6936
…mmit (#6936) Review follow-ups on b796729: - Split the settings write into persist and catalog invalidation. Removal now puts the receipt back only when the persist step itself fails; once settings.json has changed, the episode is over and the receipt stays gone. A test seam replaces just the persist step. - Oracles: an uncommitted removal keeps settings and receipt intact and a retry restores the user's value; when the receipt cannot be put back either, the original settings error still surfaces. - The English guide, the seven translations and structure/runtime.md now say the original value comes back only when OpenCodex could record it and it was not changed since. Refs #6936
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No merge-blocking issue is identified for the receipt rollback and NO_PROXY guidance changes; merge after normal checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (9 skipped: 9… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the main change: preserving the NO_PROXY receipt after failed removal, with documentation follow-ups. It is specific, concise, and related to the changeset. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (9 skipped: 9 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
-
- Commit to this branch
- Create a new PR
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Owner
Author
|
Maintainer integration into
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6938 (refs #6936), which was merged at head
3588bb4a5while these review fixes were in progress. This lands CodeRabbit's four findings on that head, plus the follow-up review of the first fix.removeClaudeInterceptSettingsinvalidates theNO_PROXYreceipt before writingsettings.json. If that write fails, the removal did not happen, so the receipt is put back and a later removal can still restore the user's value. The settings write is now split into a persist step and catalog invalidation, and only the persist step is covered: oncesettings.jsonhas changed, the episode is over and the receipt stays gone.0.0.0.0under "loopback and unspecified hosts" rather than as loopback.structure/runtime.mdnow say the originalNO_PROXYcomes back only when OpenCodex could record it and it was not changed since; otherwise the current value, including the added entries, is kept.NO_PROXYguidance from the English guide, with the same conditions.Verification
bun teston the 14 directly affected files (including the newclaude-intercept-no-proxyoracles O13 and O14): 355 pass, 0 fail.bun run typecheck,bun run structure:check,bun run privacy:scan: pass.docs-sitebun run build: complete.dev; the changed lines match the original follow-up diff exactly.bun run testwas not run locally (shared machine, load-sensitive timing tests seen earlier); CI covers it on this head.Checklist
NO_PROXYvalues; every receipt mutation passes the real-home guard; the 405 body is static.Summary by CodeRabbit
NO_PROXY, allowing local MCP servers—including*.localhosthosts—to bypass the proxy. Existing entries are preserved, and only missing addresses are added.NO_PROXYvalue is restored only if it was recorded and hasn’t changed; otherwise, the current value is kept.NO_PROXYsettings.