Skip to content

fix(claude): register subagents after first-party setup - #6484

Merged
lidge-jun merged 3 commits into
devfrom
codex/claude-1p-subagent-settings
Oct 3, 2026
Merged

lidge-jun merged 3 commits into
devfrom
codex/claude-1p-subagent-settings

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Saving Claude Code first-party settings or successfully persisting Claude Desktop first-party setup now attempts the existing agent-roster reconciliation before responding. Previously, those dedicated success paths skipped the ordinary settings-save sync, so missing ocx-* definitions remained missing until a separate sync or launch.
  • Repeated setup repairs missing definitions. Failed/rolled-back setup and unsaved Desktop partial success do not register agents; injection opt-out and user-owned files retain their existing protections.
  • Adds ten isolated filesystem/API regression cases and updates English/Korean guidance. No GUI change or new configuration field.

Verification

  • New regression suite: 10 pass, 0 fail. Before the runtime fix: 4 pass, 6 fail.
  • Existing management, Desktop, agent generation/startup and layout suites: 141 pass, 0 fail.
  • bun run typecheck, bun run structure:check, bun run privacy:scan, and git diff --check: passed.
  • cd docs-site && bun install --frozen-lockfile && bun run build: passed; 561 pages and 77,818 internal links checked.
  • The local full suite was stopped at the user's explicit instruction (exit 143); it is not passing evidence. No further local tests, builds, typechecks or QA ran. Independent implementation/security review returned PASS with no blockers.
  • Final acceptance: Cross-platform CI run 37096488218, attempt 1, pull_request event, completed successfully for head 3465fc0fc88142f3ab91e5666eb6cca6374cc943, including all four test shards and the ci aggregate. Platform jobs omitted by the workflow are skipped, not claimed as passing.
  • Maintainer integration: the user explicitly requested merge into dev. Current maintainer lidge-jun integrates under MAINTAINERS.md without a second maintainer approval, after exact-head CI and independent source/security review. This is not self-approval. The user requested no post-merge dev monitoring.
  • Local results above predate that instruction and are recorded only as historical execution evidence.
  • Scope limitation: no packaged app installation or live paid-provider request is part of this change. Generated definitions are loaded by subsequent Claude sessions.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: eb71d1bd-dca3-4570-8b3a-073bd5e5c8a3
📥 Commits

Reviewing files that changed from the base of the PR and between 4b74668 and 3465fc0.

📒 Files selected for processing (10)
  • devlog/_fin/261003_claude_1p_agents/000_plan.md
  • devlog/_fin/261003_claude_1p_agents/010_registration.md
  • devlog/_fin/261003_claude_1p_agents/090_summary.md
  • docs-site/src/content/docs/guides/claude-code.md
  • docs-site/src/content/docs/ko/guides/claude-code.md
  • scripts/test-layout/layout.json
  • src/server/management/agent-settings-routes.ts
  • structure/runtime.md
  • tests/claude-integration/claude-first-party-agent-sync.test.ts
  • tests/fixtures/test-layout-expected.json
 __________________________________________
< Lint long and prosper with cleaner code. >
 ------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Oct 3, 2026
@lidge-jun
lidge-jun marked this pull request as ready for review October 3, 2026 04:34
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 3, 2026 04:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T04:37:44.654460Z 3465fc0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun merged commit 8efd79c into dev Oct 3, 2026
39 of 41 checks passed
@lidge-jun
lidge-jun deleted the codex/claude-1p-subagent-settings branch October 3, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant