Repository navigation
fix(desktop): quote Windows Start at Login executable path - #6479
Yuxin-Qiao wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. Hygiene✅ Deterministic PR hygiene checks passed. |
) Windows Start at Login registered an ambiguous unquoted executable path. Carry the Windows-only quoted writer and enabled-entry migration while preserving opt-outs. Native Windows registry and upgrade verification remains required for lidge-jun#6473. Carries lidge-jun#6479 by @Yuxin-Qiao. Co-authored-by: Yuxin-Qiao <104957188+Yuxin-Qiao@users.noreply.github.com>
|
Superseded by the integration in #6487, with reviewed follow-up fixes in #6490 and Windows validation repairs in #6494/#6495, all merged into The Windows autostart executable quoting implementation was carried. Real Start at Login acceptance remains tracked separately in #6473; closing this replaced code PR does not close that issue. Original carry commit: Closing this PR as superseded, not claiming that its original head was merged. Thank you for the contribution. |
Summary
"<executable>" --autostartthrough a Windows-only registration helper for first-run setup, manual enables, and migration.Closes #6473
Verification
cargo checkof the production registration helper against winreg 0.55.0 passed in an isolated compile harness with a stub AppHandle; this does not validate the complete Windows application.cargo check --lockedpassed with TAURI_CONFIG excluding missing generated bundle resources. No packaged build or Windows login/registry integration test was performed.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.