Skip to content

fix(desktop): quote Windows Start at Login executable path - #6479

Closed
Yuxin-Qiao wants to merge 1 commit into
lidge-jun:devfrom
Yuxin-Qiao:codex/6473-windows-autostart-quoting
Closed

Yuxin-Qiao wants to merge 1 commit into
lidge-jun:devfrom
Yuxin-Qiao:codex/6473-windows-autostart-quoting

Conversation

@Yuxin-Qiao

@Yuxin-Qiao Yuxin-Qiao commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Windows desktop Start at Login currently writes an unquoted executable path, so an installation under Program Files produces an ambiguous startup command. Write "<executable>" --autostart through a Windows-only registration helper for first-run setup, manual enables, and migration.
  • Revisit the old migration marker once on Windows, rewriting only entries already enabled. Preserve tray/Task Manager opt-outs, the plugin registration name, and explicit-enable behavior. macOS and Linux continue using the plugin.
  • Update the desktop guide and architecture contract. No interface changes.

Closes #6473

Verification

  • Desktop Bun tests: 296 passed, 2 Windows-only PowerShell cases skipped on macOS.
  • Rust command formatter: 3 tests passed (Program Files, Unicode/no-space paths, invalid paths).
  • Windows-target cargo check of the production registration helper against winreg 0.55.0 passed in an isolated compile harness with a stub AppHandle; this does not validate the complete Windows application.
  • Native macOS cargo check --locked passed with TAURI_CONFIG excluding missing generated bundle resources. No packaged build or Windows login/registry integration test was performed.
  • TypeScript typecheck, privacy scan, structure checks, Rust formatting, and documentation build (561 pages) passed.
  • Full repository tests were not run for this desktop-scoped draft. Keep draft pending full validation, Windows verification, and explicit security review of startup registration/dependency handling.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • Required local validation passed; commands, results, and any full-suite exception are documented.

  • I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
  • ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

Hygiene

✅ Deterministic PR hygiene checks passed.

robin-bially pushed a commit to robin-bially/opencodex that referenced this pull request Oct 3, 2026
)

Windows Start at Login registered an ambiguous unquoted executable path.
Carry the Windows-only quoted writer and enabled-entry migration while preserving opt-outs.
Native Windows registry and upgrade verification remains required for lidge-jun#6473.

Carries lidge-jun#6479 by @Yuxin-Qiao.
Co-authored-by: Yuxin-Qiao <104957188+Yuxin-Qiao@users.noreply.github.com>
@lidge-jun

Copy link
Copy Markdown
Owner

Superseded by the integration in #6487, with reviewed follow-up fixes in #6490 and Windows validation repairs in #6494/#6495, all merged into dev.

The Windows autostart executable quoting implementation was carried. Real Start at Login acceptance remains tracked separately in #6473; closing this replaced code PR does not close that issue.

Original carry commit: b0b884b2c940ed80de3e47256bb2f878882679c1. Attribution to @Yuxin-Qiao is preserved in the integration history and merge trailers. The final integrated candidate passed the complete cross-platform CI run.

Closing this PR as superseded, not claiming that its original head was merged. Thank you for the contribution.

@lidge-jun lidge-jun closed this Oct 3, 2026
@lidge-jun lidge-jun mentioned this pull request Oct 4, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working superseded

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants