fix(service): scope Windows scheduler probes to the root task and re-probe deleted registrations by devin-ai-integration[bot] · Pull Request #6401 · lidge-jun/opencodex

devin-ai-integration · 2026-10-01T13:35:44Z

Summary

Scope Scheduler CSV and PowerShell state probes to the root \opencodex-proxy task. A same-named task in another folder must not supply presence or state for root-targeted stop operations.
Read registration XML only for a running manager. When state/XML becomes unreadable, re-probe presence once: proven deletion allows the existing stray-wrapper checks; present or unknown registrations continue to refuse.
Native Windows probes reproduced the folder-name mismatch before the fix. Unknown registrations and surviving/unreadable wrappers remain fail-closed.

Verification

Refreshed from dev at 06cc3815c06a10120d89ef986c46be95be37f28a without rewriting branch history, including the accepted upstream role-route and owner-registry ACL fixture corrections. Targeted verification: role routes 7 passed; owner-registry ACL 6 passed. Required CI passed at 3dbd9d8d6ef231729a34113754fbf626008b93b1: zero failed and zero pending checks (platform/path-inapplicable checks remain skipped).
Focused Windows tests: 65/65 passed; five regressions failed against the original behavior.
bun run typecheck, bun run structure:check: passed.
Full test:changed exceeded the local Windows 900-second cap; CI remains the full-suite gate.
Real registered-Scheduler CLI lifecycle passed on combined d50be3427 with this PR, fix(cli): stabilize guarded-stop re-verification and report the failing guard fact #6402, and fix(service): bound every Windows manager command the guarded stop depends on #6403. On a separate Windows VM with both managers initially absent: installed the root task in an isolated home, verified the wscript → cmd → Bun chain and supported approval, then guarded-stop returned runtimeDown: true in 49.4s. The task became Ready, the port closed, and all three approved processes exited. Repair/start succeeded; uninstall plus explicit ocx stop restored the absent-manager baseline.
WinSW account/password-dependent lifecycle remains untested. This CLI test does not claim native Tauri registered-service takeover coverage.

Checklist

Scope stays focused and avoids unrelated cleanup.
Docs or release notes were updated when needed.
Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.

Link to Devin session: https://app.devin.ai/sessions/a8795b27d4114aa6be37a88565e404b2
Open in Devin Desktop: https://app.devin.ai/desktop/session/a8795b27d4114aa6be37a88565e404b2?variant=devin

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.

…probe deleted registrations Three probe-scoping defects in the guarded Windows manager proof turned a provable absent verdict into a permanent unknown (approval-changed) or a permanent failed stop: - windowsSchedulerCsvIncludesTask treated a backslash as a name boundary, so a same-named task inside a task folder (\Tools\opencodex-proxy) read as present while every /tn operation resolves a bare name in the root folder only — the bound read/stop then failed on a task nothing could reach. - windowsScheduledTaskState ran Get-ScheduledTask -TaskName without -TaskPath, a folder-agnostic filter that returns foreign task state and arrays. - inspectWindowsSchedulerManager read the registration XML before the state check, so an unreadable registration blocked the absent verdict an inert task does not need; and a task deleted between probes was indistinguishable from an unreadable one. The XML now loads only on the running path, and the unanswerable state/XML reads re-probe presence: proven-gone gets the stray-wrapper inert verdict, persisting or unanswerable stays unknown. observeWindowsGuardedManagerStopped re-probes the same way before failing closed, and proven absence still owes the unreadable former-manager check. Verified live on Windows Server 2022: \DevinProbe\opencodex-proxy exists while schtasks /query /tn, /end and /xml all fail root-scoped, the CSV listing emits "\DevinProbe\opencodex-proxy", and Get-ScheduledTask -TaskName returns the foldered task's state plus arrays for duplicate names. Regression tests pin each failure and the preserved fail-closed cases. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration · 2026-10-01T13:35:46Z

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

Disable automatic comment, CI, and merge conflict monitoring

coderabbitai · 2026-10-01T13:35:52Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ba00cf03-ba33-4723-b87c-597ddfdd512e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-01T13:52:07Z

✅ Deterministic PR hygiene checks passed.

github-actions · 2026-10-01T15:03:32Z

⏳ DRAFT

review readiness checklist open (0/0 boxes ticked).

What to do

Tick all four boxes in the PR description once you're done (currently 0/0).

Review readiness checklist

⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
⬜ I resolved all correct Codex and CodeRabbit findings.
⬜ My PR is ready for review.

0/0 boxes ticked.

Automatic draft conversion failed. Please convert this pull request to a draft manually until every box above is ticked.

…90860555-win-scheduler-probe-scope

# Conflicts: # structure/runtime.md

lidge-jun · 2026-10-02T00:09:44Z

Maintainer integration record (MAINTAINERS.md, dev-only)

Actor: @lidge-jun (admin). The project owner asked on 2026-10-02 to land the Devin Windows hardening series, via PABCD plan unit devlog/_plan/261002_devin_windows_hardening_landing.
Exact head: 914c05241eb06ae01786248ff85ae971ebbac2c6.
PR-lane Cross-platform CI at this head: run 36943138910 success. The PR lane skips the Windows and macOS shards.
Union proof on Windows and macOS: codex/windows-hardening-2.76 (29b1c39b2b = dev + fix(service): bound every Windows manager command the guarded stop depends on #6403, fix(service): scope Windows scheduler probes to the root task and re-probe deleted registrations #6401, fix(cli): stabilize guarded-stop re-verification and report the failing guard fact #6402, fix(desktop): allow Windows guarded takeover to finish within one bounded budget #6400, fix(update): release the Bun updater lease around service-manager starts (#5760) #6407, fix(update): release the restart lease before the service refresh (#5760) #6404) passed full lane=all run 36938434654 on attempt 2. Attempt 1 failed only windows 9/9, on an unrelated catalog-serialization child-spawn timeout. In the Windows shards, windows-guarded-manager (42), windows-scheduler-install-verification (24), winsw-stop-hardening (2), windows-service-wrappers (39), update-restart-lease (7), cli-stop-json (22), managing-cli (10) and process-state (16) all executed with 0 failures.
Independent audit PASS: absent comes only from a CSV query that exits 0 with no root-level row, never from localized text; root scoping covers every probe the stop depends on. Maintainer merge of dev resolves the structure/runtime.md prose conflict with fix(service): bound every Windows manager command the guarded stop depends on #6403 by keeping both sentences.
Local suites: not run, by explicit owner instruction. Hosted CI is the only execution evidence.
Authored by Devin (app/devin-ai-integration) for the project owner.

chatgpt-codex-connector · 2026-10-02T00:09:50Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-02T00:13:29.647264Z	`914c052`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 914c05241e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-02T00:13:27Z

+    return io.winTaskProbe().status === "absent"
+      ? inertVerdict()


Refresh the process snapshot after proving task deletion

When the task starts after the winProcs() snapshot, reports running, and is then deleted before the XML read, this branch returns inertVerdict() using the stale strays array. A deleted registration can still leave its wrapper alive, so the guarded stop can classify the manager as absent, signal only the approved child, and let the surviving wrapper respawn it. Re-read the process list after the absence re-probe before returning absent; the state-unknown re-probe and post-stop paths have the same stale-snapshot issue.

Useful? React with 👍 / 👎.

devin-ai-integration Bot requested review from Ingwannu and lidge-jun as code owners October 1, 2026 13:35

github-actions Bot added the bug Something isn't working label Oct 1, 2026

devin-ai-integration Bot mentioned this pull request Oct 1, 2026

fix(service): bound every Windows manager command the guarded stop depends on #6403

Merged

7 of 11 tasks

github-actions Bot marked this pull request as draft October 1, 2026 15:03

devin-ai-integration Bot added 2 commits October 1, 2026 16:25

Merge commit '58a26f0c13e7fa7c469219d8bbd3dfca0a9e33c4' into devin/17…

2c4e4be

…90860555-win-scheduler-probe-scope

Merge commit '06cc3815c06a10120d89ef986c46be95be37f28a' into devin/17…

3dbd9d8

…90860555-win-scheduler-probe-scope

devin-ai-integration Bot marked this pull request as ready for review October 1, 2026 17:53

github-actions Bot marked this pull request as draft October 1, 2026 17:54

This was referenced Oct 1, 2026

fix(desktop): allow Windows guarded takeover to finish within one bounded budget #6400

Merged

fix(update): release the Bun updater lease around service-manager starts (#5760) #6407

Merged

Merge remote-tracking branch 'origin/dev' into rel-devin/up-6401

914c052

# Conflicts: # structure/runtime.md

lidge-jun marked this pull request as ready for review October 2, 2026 00:09

lidge-jun merged commit cfde167 into dev Oct 2, 2026
39 of 40 checks passed

lidge-jun deleted the devin/1790860555-win-scheduler-probe-scope branch October 2, 2026 00:09

lidge-jun mentioned this pull request Oct 2, 2026

fix(update): release the restart lease before the service refresh (#5760) #6404

Merged

7 of 11 tasks

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Navigation Menu

Repository navigation

fix(service): scope Windows scheduler probes to the root task and re-probe deleted registrations - #6401

fix(service): scope Windows scheduler probes to the root task and re-probe deleted registrations#6401
lidge-jun merged 4 commits into
devfrom
devin/1790860555-win-scheduler-probe-scope

devin-ai-integration Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot commented Oct 1, 2026

Uh oh!

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

lidge-jun commented Oct 2, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 2, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		return io.winTaskProbe().status === "absent"
		? inertVerdict()

Conversation

devin-ai-integration Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Checklist

Review readiness checklist

Review readiness checklist

Uh oh!

devin-ai-integration Bot commented Oct 1, 2026

Uh oh!

coderabbitai Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ DRAFT

What to do

Review readiness checklist

Uh oh!

lidge-jun commented Oct 2, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

devin-ai-integration Bot commented Oct 1, 2026 •

edited

Loading

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 2, 2026 •

edited

Loading