Repository navigation
fix(gui): bridge quota popover hover gap and link account management - #6345
Conversation
Carries #6278 with maintainer review fixes: the chip description points at the text-only quota table, and the hover bridge spans both the chip and popover widths so wide chips keep the popover open. Co-authored-by: colthreepv <2657230+colthreepv@users.noreply.github.com>
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Maintainer integration into |
Summary
Carries #6278 by @colthreepv. Moving the pointer from a quota chip to its popover crossed a small gap that closed the popover. The popover footer link to account management also did nothing. A hover bridge now keeps the popover open across the gap, and the footer links to account management.
Maintainer review added two fixes. The chip's
aria-describedbynow points at the text-only quota table, because the group it pointed at was labeled only with the provider name and lost the quota details under the accessible-description algorithm. The bridge now spans both the chip and popover widths, so wide chips no longer leave an uncovered path. A browser regression covers this, and it fails when the original bridge width is restored.Supersedes #6278.
Co-authored-by: colthreepv 2657230+colthreepv@users.noreply.github.com
Verification
bun test tests/quota-summary-bar.test.tsx10 pass,tests/quota-summary.test.ts4 pass; GUI and root typecheck,bun run build,bun run lint:gui,structure:check,privacy:scanpass.bun tests/quota-summary-hover-browser.ts(newtest:quota-hoverscript): 48 configurations and 144 gap traversals pass, plus account navigation and keyboard Tab/Enter/Escape.dev:bun x tsc --noEmit,structure:check, test-layout and file-size ratchet guards (27 pass) pass. No dependency changes;gui/package.jsononly gains the script.devtip before release.Checklist