Skip to content

fix(gui): bridge quota popover hover gap and link account management - #6345

Merged
lidge-jun merged 1 commit into
devfrom
codex/carry-6278-quota-popover
Oct 1, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/carry-6278-quota-popover

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Carries #6278 by @colthreepv. Moving the pointer from a quota chip to its popover crossed a small gap that closed the popover. The popover footer link to account management also did nothing. A hover bridge now keeps the popover open across the gap, and the footer links to account management.

Maintainer review added two fixes. The chip's aria-describedby now points at the text-only quota table, because the group it pointed at was labeled only with the provider name and lost the quota details under the accessible-description algorithm. The bridge now spans both the chip and popover widths, so wide chips no longer leave an uncovered path. A browser regression covers this, and it fails when the original bridge width is restored.

Supersedes #6278.

Co-authored-by: colthreepv 2657230+colthreepv@users.noreply.github.com

quota popover hover bridge

quota popover

Verification

  • GUI bun test tests/quota-summary-bar.test.tsx 10 pass, tests/quota-summary.test.ts 4 pass; GUI and root typecheck, bun run build, bun run lint:gui, structure:check, privacy:scan pass.
  • bun tests/quota-summary-hover-browser.ts (new test:quota-hover script): 48 configurations and 144 gap traversals pass, plus account navigation and keyboard Tab/Enter/Escape.
  • On current dev: bun x tsc --noEmit, structure:check, test-layout and file-size ratchet guards (27 pass) pass. No dependency changes; gui/package.json only gains the script.
  • Cross-platform CI for this head is deferred by the owner's instruction to one run on the final dev tip before release.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Carries #6278 with maintainer review fixes: the chip description points at the text-only quota table, and the hover bridge spans both the chip and popover widths so wide chips keep the popover open.

Co-authored-by: colthreepv <2657230+colthreepv@users.noreply.github.com>
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 1, 2026 02:21
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Oct 1, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T02:25:40.495853Z f05b408 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 17ecff52-ab7a-404a-948d-476823305d19

📥 Commits

Reviewing files that changed from the base of the PR and between ee3845f and f05b408.

📒 Files selected for processing (8)
  • docs-site/src/content/docs/guides/web-dashboard.md
  • gui/README.md
  • gui/package.json
  • gui/src/components/quota-summary-bar/QuotaSummaryBar.tsx
  • gui/src/components/quota-summary-bar/quota-summary-bar.css
  • gui/tests/quota-summary-bar.test.tsx
  • gui/tests/quota-summary-hover-browser.ts
  • structure/dashboard-and-usage.md
 _______________________________________________
< Show me the code! And I'll show you the bugs. >
 -----------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev by @lidge-jun. Carries #6278 with a Co-authored-by trailer; GUI screenshots, review fixes and verification (GUI unit tests, browser regression with 144 gap traversals, lint, build) are in the description. No dependency changes. Cross-platform CI for this head is deferred by the owner's instruction to one run on the final dev tip before release; scripts/ci/assert-mergeable-review.sh --maintainer-integration OK at this head.

@lidge-jun
lidge-jun merged commit 8ad261e into dev Oct 1, 2026
15 of 31 checks passed
@lidge-jun
lidge-jun deleted the codex/carry-6278-quota-popover branch October 1, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant