Skip to content

fix(claude): preserve Devin answers with late reasoning signatures - #6344

Merged
lidge-jun merged 1 commit into
devfrom
codex/carry-6299-devin-late-signatures
Oct 1, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/carry-6299-devin-late-signatures

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Carries #6299 by @foxytanuki. When Devin streams the visible answer and then a late reasoning signature, Claude Code could end up with an empty final result. src/claude/devin-output-order.ts holds the answer until the signature order is settled and replays it in the order Claude Code expects. A bounded hold (shared 32 MiB limit) preserves cancellation and overflow error semantics. The maintainer commit translates the new buffering note into the ja, ko, ru and zh-cn Claude Code guides; review had found it only in English.

Supersedes #6299.

Co-authored-by: foxytanuki 45069709+foxytanuki@users.noreply.github.com

Verification

  • Independent review of all changed files: no runtime defect; no new credential destination, auth or signature-control regression; retention bounded.
  • On current dev: bun test tests/claude-integration/claude-devin-output-order.test.ts tests/test-layout.test.ts tests/ci-workflows/file-size-ratchet.test.ts 33 pass / 0 fail; bun x tsc --noEmit and bun run structure:check pass. The reviewer also ran five related Devin/Claude suites and the guards: 153 pass / 0 fail. The mutation regression failed before snapshot restoration and passed after.
  • Translation accuracy checked by an independent reviewer.
  • Cross-platform CI for this head is deferred by the owner's instruction to one run on the final dev tip before release.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Carries #6299 with the buffering note translated into the ja, ko, ru and zh-cn Claude Code guides.

Co-authored-by: foxytanuki <45069709+foxytanuki@users.noreply.github.com>
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 1, 2026 02:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T02:18:57.260271Z f90c5c5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: cc2fada8-7773-4768-9ae3-dd62d2cc71ec

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea77aa and f90c5c5.

📒 Files selected for processing (13)
  • docs-site/src/content/docs/guides/claude-code.md
  • docs-site/src/content/docs/ja/guides/claude-code.md
  • docs-site/src/content/docs/ko/guides/claude-code.md
  • docs-site/src/content/docs/ru/guides/claude-code.md
  • docs-site/src/content/docs/zh-cn/guides/claude-code.md
  • scripts/test-layout/layout.json
  • src/claude/devin-output-order.ts
  • src/server/responses/run-turn-execution.ts
  • structure/clients/claude-desktop.md
  • structure/providers-and-adapters.md
  • structure/transports/byte-accounting.md
  • tests/claude-integration/claude-devin-output-order.test.ts
  • tests/fixtures/test-layout-expected.json
 ______________________________________________________________________________________________________________________
< Design with contracts. Use contracts to document and verify that code does no more and no less than it claims to do. >
 ----------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev by @lidge-jun. Carries #6299 with a Co-authored-by trailer; review and local evidence in the description. Cross-platform CI for this head is deferred by the owner's instruction to one run on the final dev tip before release; scripts/ci/assert-mergeable-review.sh --maintainer-integration OK at this head.

@lidge-jun
lidge-jun merged commit ee3845f into dev Oct 1, 2026
14 of 28 checks passed
@lidge-jun
lidge-jun deleted the codex/carry-6299-devin-late-signatures branch October 1, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant