fix(claude): preserve Devin answers with late reasoning signatures - #6344
Conversation
Carries #6299 with the buffering note translated into the ja, ko, ru and zh-cn Claude Code guides. Co-authored-by: foxytanuki <45069709+foxytanuki@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Maintainer integration into |
Summary
Carries #6299 by @foxytanuki. When Devin streams the visible answer and then a late reasoning signature, Claude Code could end up with an empty final result.
src/claude/devin-output-order.tsholds the answer until the signature order is settled and replays it in the order Claude Code expects. A bounded hold (shared 32 MiB limit) preserves cancellation and overflow error semantics. The maintainer commit translates the new buffering note into the ja, ko, ru and zh-cn Claude Code guides; review had found it only in English.Supersedes #6299.
Co-authored-by: foxytanuki 45069709+foxytanuki@users.noreply.github.com
Verification
dev:bun test tests/claude-integration/claude-devin-output-order.test.ts tests/test-layout.test.ts tests/ci-workflows/file-size-ratchet.test.ts33 pass / 0 fail;bun x tsc --noEmitandbun run structure:checkpass. The reviewer also ran five related Devin/Claude suites and the guards: 153 pass / 0 fail. The mutation regression failed before snapshot restoration and passed after.devtip before release.Checklist