Repository navigation
Conversation
|
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Repository guideline files applied to this review (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Grok compatibility version and user-agent version change from ChangesGrok compatibility version
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change updates Grok compatibility metadata without changing request behavior. No actionable merge-blocking issue is established. Live xAI acceptance was not tested. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* fix(xai): report a current Grok CLI version on the OAuth path
xAI now answers Grok OAuth requests that report a client version below 1.0.13 with HTTP 426 ("Your Grok CLI version (0.2.93) is outdated"), so every SuperGrok OAuth request failed. Report 1.0.25, the current stable Grok CLI, in x-grok-client-version and the User-Agent.
Carries #6339.
Co-authored-by: unsafe9 <24631203+unsafe9@users.noreply.github.com>
* test(xai): pin Grok compatibility header regression
---------
Co-authored-by: unsafe9 <24631203+unsafe9@users.noreply.github.com>
|
Landed on |
…jun#6341) * fix(xai): report a current Grok CLI version on the OAuth path xAI now answers Grok OAuth requests that report a client version below 1.0.13 with HTTP 426 ("Your Grok CLI version (0.2.93) is outdated"), so every SuperGrok OAuth request failed. Report 1.0.25, the current stable Grok CLI, in x-grok-client-version and the User-Agent. Carries lidge-jun#6339. Co-authored-by: unsafe9 <24631203+unsafe9@users.noreply.github.com> * test(xai): pin Grok compatibility header regression --------- Co-authored-by: unsafe9 <24631203+unsafe9@users.noreply.github.com> (cherry picked from commit 6f2f6ae)
Problem
xAI now rejects Grok CLI OAuth requests that report a client version below 1.0.13:
OpenCodex hardcodes
0.2.93inXAI_GROK_COMPATIBILITY, sent asx-grok-client-versionand in theUser-Agenton the OAuth (SuperGrok) path, so every Grok OAuth request fails regardless of the locally installed grok CLI.Change
Bump
XAI_GROK_COMPATIBILITY.version/userAgentto1.0.22(current Grok CLI). Both constants derive from this single source; no other0.2.93references exist insrcortests.Verification
bun teston the 5 test files referencing xai-transport / XAI_GROK: 175 pass, 0 fail. Not verified against live xAI.Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit