Repository navigation
fix(devin): apply Cognition blocklist rewrites to the system prompt - #6328
Conversation
Carries #6281 unchanged plus maintainer review fixes; the contributor gate re-drafted the original after the maintainer push. Co-authored-by: lonefisher <132996955+lonefisher@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Maintainer integration into |
Summary
Carries #6281 by @lonefisher. The contributor gate returned the original to draft after a maintainer review commit, so the final state lands here with author credit.
Cognition's request blocklist refused every Codex turn because Codex injects the clause
asking the user if they want to allow the action in \justification` parameter` into the system prompt. This adds a live-verified, meaning-preserving rewrite for that clause and applies the sanitizer to request field #2, the leading system prompt, in addition to tool descriptions. Conversation text, replayed thinking and tool-call arguments stay byte-exact.The maintainer review commit strengthens the regression: the original test accepted a rewritten tool description as proof of system-prompt sanitization and still passed with the system rewrite disabled. It now asserts decoded field #2 independently, and that mutation fails.
Closes #6281
Co-authored-by: lonefisher 132996955+lonefisher@users.noreply.github.com
Verification
dev: nine focused Devin suites 202 pass / 0 fail;bun run typecheck,structure:check,privacy:scanpass.dev:bun x tsc --noEmitpasses; the PRs' test files 124 pass / 0 fail.devtip after this landing batch.Checklist