Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
리뷰 · 우선순위 54 / 80OpenCodex가 켜져 있고 Codex 연동이 켜져 있으면, Codex Desktop이 쓰는 라인 - 라인 - 라인 - 라인 - 메인테이너의 판단이 필요한 지점 새 모델 하나 때문에 시작 때와 같은 전체 동기화를 돌릴지예요. 그 길은 프로바이더 목록도 다시 가져오고, 끝나면 캐시를
너의 추천 바탕 머지 전에 세 곳을 고치세요. 698행은 실패를 삼키지 않는 동기화에 연결하거나, 카탈로그가 안 바뀌면 경고를 남기세요. 901행은 계정 모델 줄의 이름만 이미 아는 이름으로 보세요. 61행은 감시가 죽으면 한 번 다시 여세요. 469행 테스트는 준비 체크는 아직 0/4예요. 본문은 타입 검사가 기존 이 댓글은 grok-bot이 작성했습니다 |
Ingwannu
left a comment
There was a problem hiding this comment.
Reviewed exact head 2a8f4ef. Four correctness gaps still block this draft:
- The sync helper catches and suppresses its own failures, so the watcher-level catch/recovery path cannot run.
- A bare catalog slug is treated as proof that an account-qualified model was synchronized, which can leave the qualified entry absent.
- Ignoring every client_version=0.0.0 event can miss a legitimate concurrent Desktop write.
- After a watcher error the code does not establish a replacement subscription, so automatic model sync can remain disabled until restart.
The current tests do not start the real watcher or exercise debounce, stop, error, and resubscription behavior. Please make failures observable to the watcher, compare the exact qualified identity, distinguish self-writes without discarding unrelated 0.0.0 writes, and prove watcher recovery with an integration-style test.
|
Closing during triage: draft inactive since late September and now far behind dev. Happy to review a fresh rebase on dev. |
Summary
models_cache.jsonwhile OpenCodex is running and reconcile the native model catalog when a newly available account-native model appears.Verification
bun test tests/codex-integration/native-model-toggle.test.ts— 42 passed.git diff --check— passed.bun run typecheck— not clean because unrelated existing errors insrc/server/claude-messages.ts:699andsrc/server/responses/fetch-helpers.ts:443(RequestInit.timeoutis missing from the resolved dependency types).UNKNOWN_CERTIFICATE_VERIFICATION_ERRORwhile downloading packages.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.