Repository navigation
test(proxy): skip case-distinct bypass cases on Windows - #6134
Conversation
Windows environment names are case-insensitive, so NO_PROXY and no_proxy are one variable there. Five macOS "auto" proxy cases assert that the two bypass lists differ and failed on windows 6/9 of the final train 4 dev CI run. Skip them on win32 the same way the neighbouring WebSocket bypass case already does; the macOS discovery path itself only runs on darwin.
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughProxy environment tests that rely on distinct uppercase and lowercase variable names now skip on Windows. The change covers separate bypass lists, an uppercase-only localhost route, and inherited SOCKS/HTTP bypass assertions. ChangesProxy environment test compatibility
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The Windows skips are limited to assertions that cannot apply when environment names are case-insensitive; no merge-blocking issue was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Maintainer dev integration (MAINTAINERS.md, dev-only, no second approval): release train 4 coordinator fix for the final dev CI run 36346985953 (head b383def), where windows 6/9 failed on five case-distinct NO_PROXY/no_proxy assertions. Exact head c130aa0. Test-only; macOS focused file 43/0 and typecheck pass locally. Windows proof comes from the post-merge Cross-platform CI run on dev. |
Summary
The final Cross-platform CI run for release train 4 on
dev(run 36346985953, head b383def) failed onwindows 6/9. Five cases intests/server/proxy-env-macos.test.ts, added with the macOSproxy: "auto"discovery work, assumeNO_PROXYandno_proxycan hold different values. On Windows, environment variable names are case-insensitive, so writingno_proxyoverwritesNO_PROXYand the assertions cannot hold.This change skips those cases on
win32, the same way the neighbouring WebSocket bypass case in the file already does. In the parameterized "inherited %s wins" test, only the upper/lower route assertion is guarded. The discovery path under test only runs ondarwin, so no production behavior changes.Verification
bun test tests/server/proxy-env-macos.test.tson macOS: 43 pass, 0 fail.bun run typecheck: passed.devafter this merges. Per-PR CI was intentionally not run for release train 4 because of runner congestion.Checklist
Summary by CodeRabbit