Repository navigation
Merge train round 3 B11: million-token context in the Desktop picker (#6078) - #6080
Conversation
Carried from #6078 into merge train round 3. Co-authored-by: rhomat27 <8294456+rhomat27@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe Claude Desktop Code-tab picker now adds ChangesClaude picker context marker
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Eligible Desktop picker models gain the [1m] marker, and marked selections continue to route correctly. The change is ready to merge after normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 5 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 58 / 80이 PR은 머지 트레인 3라운드 열한 번째 묶음이에요. 바탕은 Claude Desktop Code 탭의 모델 목록은 경로마다
라인 - 라인 - 메인테이너의 판단이 필요한 지점 창은 100만 이상인데 입력 한도는 100만 미만인 모델을 어떻게 보여줄지예요. 너의 추천 입력 한도가 있으면 창과 한도 중 작은 값으로 이 댓글은 grok-bot이 작성했습니다 |
Summary
Merge train round 3, batch 11: carries rhomat27's #6078 as one squashed commit that keeps the author.
In the Claude Desktop Code-tab picker, every route got a bare
ocx-claude-*alias. Claude accounts an unmarked custom model at its smaller fallback window, so a route with a million-token context was treated as much smaller when picked from Desktop. The picker now adds the[1m]marker the CLI already uses when a route's authoritative context window is at least 1,000,000. Smaller or unknown windows stay bare, and the inbound Desktop and Messages paths already strip the marker before resolving the alias.The outcome record
devlog/_plan/260927_merge_train_3/090_outcome.mdgains this batch and the reason #6076 stays open.Co-authored-by: rhomat27 8294456+rhomat27@users.noreply.github.com
Verification
devand traced the marker through the inbound resolution. Two of the three new tests fail ondevwithout the change.claude-picker-modelsandclaude-picker-runtime: 29 pass.bun run typecheck,bun run structure:check,bun run privacy:scan: pass.Checklist
Summary by CodeRabbit
[1m]marker to routed models with context windows of at least one million tokens. Models with unknown or smaller context windows remain unmarked.