Skip to content

test(windows): verify sibling recycle without POSIX cleanup assumption #5997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 2 commits into from
Sep 26, 2026
Merged

test(windows): verify sibling recycle without POSIX cleanup assumption #5997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e03cdea
test(windows): observe recycled sibling process exit
lidge-jun Sep 26, 2026
5277122
Merge current dev before Windows recycle verification
lidge-jun Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/clients/client-link-runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,15 @@ test("an ended link recycles a connected sibling after listener cleanup", async
if (child) await child.exited;
if (replacementPid !== null) {
try { process.kill(replacementPid, "SIGTERM"); } catch { /* already exited */ }
await waitFor(() => existsSync(join(home, "runtime-port.json")) ? null : true, "replacement shutdown");
await waitFor(() => {
try { return process.kill(replacementPid, 0) ? null : true; }
catch { return true; }
}, "replacement process exit");
// Windows SIGTERM is TerminateProcess, so no signal/exit handler removes the runtime
// record. The fixture cleanup owns that stale file after proving the process is gone.
if (process.platform !== "win32") {
await waitFor(() => existsSync(join(home, "runtime-port.json")) ? null : true, "replacement runtime cleanup");
}
}
if (priorHome === undefined) delete process.env.OPENCODEX_HOME;
else process.env.OPENCODEX_HOME = priorHome;
Expand Down
Loading