Skip to content

fix(release): correct lipo architecture verification arguments - #5535

Merged
lidge-jun merged 1 commit into
devfrom
codex/release-lipo-argument-order
Sep 22, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/release-lipo-argument-order

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

  • Fix the lipo architecture assertion introduced in fix(desktop): preserve packaged CLI and assemble universal sidecar #5530: -verify_arch consumes every following argument as an architecture, so the input filename must precede it.
  • Update the workflow assertion to cover the complete argument order. No signing, publication or permission changes.
  • Owner-authorized immediate dev integration, then main/preview carry; CI remains required for publication.

Verification

  • Preview dry-run 35720315462, macOS job106721669999, printed the invalid architecture error and lipo <input_file> <command> usage. The universal binary creation completed before this assertion failed.
  • Linux AppImage/deb packaging and extracted CLI byte equality/version probe passed in this run.
  • Source/security review; hosted verification pending. Local tests/typechecks/builds/probes: NOT RUN by owner instruction. Commit/push use --no-verify.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed: existing architecture contract is unchanged.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 22, 2026 11:26
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@lidge-jun
lidge-jun merged commit 7bd9985 into dev Sep 22, 2026
4 of 14 checks passed
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: dc5dfb61-a233-43db-a988-0263338384c7

📥 Commits

Reviewing files that changed from the base of the PR and between a5e8047 and bda9bef.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • tests/ci-workflows/release-desktop-scripts.test.ts
 _______________________________________________
< Somewhere, a linter just sighed dramatically. >
 -----------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun
lidge-jun deleted the codex/release-lipo-argument-order branch September 22, 2026 11:26
@github-actions github-actions Bot added the bug Something isn't working label Sep 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant