test(layout): register the StepFun provider test in both layout maps - #5335
Merged
Merged
Conversation
Co-authored-by: Flowershangfromthebranches <flowershangfromthebranches@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
added
the
chore
This was referenced Sep 20, 2026
lidge-jun
added a commit
that referenced
this pull request
Sep 20, 2026
…ntories" This reverts commit e10b98f. The same registration landed on dev as #5335 while this stack was in flight, and the rebase kept both because the two insertions chose different neighbours. Two entries for one key is not a second registration, it is a JSON object whose last value silently wins, so the duplicate goes rather than the one already on dev.
lidge-jun
added a commit
that referenced
this pull request
Sep 20, 2026
…ntories" This reverts commit e10b98f. The same registration landed on dev as #5335 while this stack was in flight, and the rebase kept both because the two insertions chose different neighbours. Two entries for one key is not a second registration, it is a JSON object whose last value silently wins, so the duplicate goes rather than the one already on dev.
lidge-jun
added a commit
that referenced
this pull request
Sep 20, 2026
…ntories" This reverts commit e10b98f. The same registration landed on dev as #5335 while this stack was in flight, and the rebase kept both because the two insertions chose different neighbours. Two entries for one key is not a second registration, it is a JSON object whose last value silently wins, so the duplicate goes rather than the one already on dev.
lidge-jun
added a commit
that referenced
this pull request
Sep 20, 2026
* fix(desktop): keep proc-macro symbols in the release profile cargo applies profile.release strip to build scripts and proc macros. A stripped proc-macro dylib cannot be loaded by rustc, so the release build failed at ctor_proc_macro with a bare can't-find-crate that named the macro instead of the profile. The dev profile compiled the same graph. * docs(devlog): lock the desktop stabilization roadmap * docs(devlog): state per-phase acceptance evidence * fix(cli): report a dashboard bundle older than its sources The dashboard is a build artifact served from gui/dist, so a checkout that moves forward without bun run build:gui keeps serving the previous bundle. Nothing fails: the proxy answers, the page loads, and every feature added since the last build is absent, which reads as the feature being broken rather than unbuilt. A five-day-old bundle hid the whole menu-bar and widget section of the Usage page that way. ocx status now compares the newest source mtime under gui/src against the served bundle and names the rebuild. It reports and never rebuilds: a proxy that compiled a frontend while starting would trade silent staleness for a slow, surprising start. Unknown is not stale. A packaged install ships no gui/src beside the bundle, and a missing bundle is a separate condition, so neither raises the warning. * docs(devlog): plan the wp2 build-state guards * build(desktop): give the local build a path that needs no signing key tauri build always writes the updater archive, because createUpdaterArtifacts is true and plugins.updater.pubkey is set, and then refuses to finish without TAURI_SIGNING_PRIVATE_KEY. Both bundles already exist when that happens, so a local build reports a failure for a signing step it was never meant to perform and a wrapper cannot tell it apart from a real one. bun run build:local turns the artifact off for that invocation instead of leaving the key required and unmet, so nothing is skipped unsigned. Selecting bundle targets is not enough: createUpdaterArtifacts is a config flag, so --bundles app,dmg still produced the updater archive and still failed. The committed config is unchanged and the release path still refuses to publish an unsigned updater artifact. * fix(ci): stop the desktop lockfile shadowing the root one and name the freshness test for its domain Two failures on the exact head of this branch, both real. The widget job installs the desktop workspace with --frozen-lockfile on Bun 1.3.14. A bun.lock written inside desktop/ by a newer Bun shadows the root lockfile for any command run from that directory, so the job failed with "Unknown lockfile version" followed by "lockfile had changes, but lockfile is frozen" before it built anything. That file was committed by accident; the root lockfile is the only one this repository keeps, and .gitignore now says so. tests/server/gui-bundle-freshness.test.ts was registered as server in both inventories, but the gui domain seed claims ^(?:dashboard|gui|models|qwen|tencent)-, so resolveTarget answered gui and the membership oracle reported the file twice - once as a wrong target against the fixture and once as a seed disagreeing with the table. Renaming it to server-gui-bundle-freshness.test.ts puts the name in the domain that owns it rather than pinning an override, which is what that guard is there to prevent. * test(layout): register the StepFun provider test in both inventories tests/providers/stepfun-provider.test.ts landed on dev without an entry in either inventory, and no regex seed resolves its name, so the membership oracle has been failing on dev and on every branch cut from it since. Registering it under providers restores the gate for everyone rather than only for this stack. * Revert "test(layout): register the StepFun provider test in both inventories" This reverts commit e10b98f. The same registration landed on dev as #5335 while this stack was in flight, and the rebase kept both because the two insertions chose different neighbours. Two entries for one key is not a second registration, it is a JSON object whose last value silently wins, so the duplicate goes rather than the one already on dev. --------- Co-authored-by: codex <codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devis red at5b7f777522a0860566b77233db625f0fdefd742f:tests/ layout > every test file resolves to a domainfails on shard 1/4 and macOS 1/2, andmembership oracle > the live tree and the fixture agree entry by entryfails on shard 4/4.tests/providers/stepfun-provider.test.tswithout registering it. The name matches no seed pattern inscripts/test-layout/layout.json, soresolveTargetreturns null and the file resolves to no domain, and the fixture has no entry for it either.providersin bothscripts/test-layout/layout.jsonandtests/fixtures/test-layout-expected.json, which is where the file already sits.Verification
resolveTargetfromscripts/test-layout/schema.tsover the livetests/tree:unresolved,stragglersandmisplacedare all empty after the change, andstepfun-provider.test.tswas the only entry inunresolvedbefore it.Checklist