Repository navigation
docs(devlog): correct the 2.57.0 Windows evidence and record the after-the-fact dispatch - #4840
Conversation
…r-the-fact dispatch The release record claimed the candidate run covered all six Windows shards. It did not: platform-windows is dispatch-only, so both the candidate push run 35131181996 and the release-SHA push run 35133242171 skipped it, and the aggregate ci check accepts a skipped producer as a pass. The green Windows evidence that existed belonged to 1504caa, the #4825 lane head, not to the commit 2.57.0 was published from. Dispatch 35139132889 has now run lane=all at 44de45d, the exact published SHA, and all six shards passed individually. The release is sound; the record was not. No local suite, typecheck, build, or install was run.
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
documentation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe release plan corrects Windows CI evidence for candidate and release-SHA push runs. It records a later exact-SHA dispatch with six passing Windows shards and documents deferred event-aware gating and mandatory validation work. ChangesRelease evidence
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The release documentation correction is mergeable; the proposed formatting issues do not establish a blocking problem. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 75 / 80이 PR은 코드를 고치는 게 아니라, 2.57.0 출시 기록( 문제의 핵심은 워크플로 설계와 기록 문장이 어긋난 점입니다. 그다음에 붙은 “초록 Windows 증거”도 커밋이 달랐습니다. 출시 시점에 실제로 초록이었던 Windows 런은 지금 라인 - 문서만 바꾸므로 런타임·기본값·워크플로 동작 회귀는 없습니다
후속 문단의 “CI-integrity lane” - 지금 열린 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 298c233b07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| it tells the reader exactly what to do instead of republishing. A pending verification here means | ||
| wait and re-read, not cut another version. | ||
|
|
||
| ## Correction: Windows was never run on the candidate or the release SHA |
There was a problem hiding this comment.
The heading says Windows was never run on the release SHA, but lines 67–74 immediately document a successful after-the-fact dispatch at that exact SHA. This makes the release record internally contradictory, especially for readers scanning headings; rename it to state that Windows was not run on the candidate or release SHA before publication.
Useful? React with 👍 / 👎.
…r-the-fact dispatch (lidge-jun#4840) The release record claimed the candidate run covered all six Windows shards. It did not: platform-windows is dispatch-only, so both the candidate push run 35131181996 and the release-SHA push run 35133242171 skipped it, and the aggregate ci check accepts a skipped producer as a pass. The green Windows evidence that existed belonged to 1504caa, the lidge-jun#4825 lane head, not to the commit 2.57.0 was published from. Dispatch 35139132889 has now run lane=all at 44de45d, the exact published SHA, and all six shards passed individually. The release is sound; the record was not. No local suite, typecheck, build, or install was run.
1 participant
Summary
The 2.57.0 release record claimed the candidate run covered "all six Windows shards". It did not, and that sentence is the one a future release would have trusted.
platform-windowsis dispatch-only by design (.github/workflows/ci.ymlgates it ongithub.event_name == 'workflow_dispatch'), so on anypushorpull_requestevent the six shards reportskipped— and the aggregatecicheck accepts askippedproducer as a pass. Both runs cited in the record are push runs:windows N/6351311819961831193294(candidate)3513324217144de45dfdc(release SHA)The green Windows evidence that did exist was run
35134620067on1504caaa83, the #4825 lane head — not the candidate and not the commit the package was published from. That is why the claim read as true: it was attached to the wrong commit.The gap is now closed after the fact. Dispatch
35139132889ranci.yml --ref main -f lane=allat44de45dfdc, the exact commit@bitkyc08/opencodex@2.57.0was published from, and all six shards passed individually. 2.57.0 is sound on Windows; what failed was the evidence discipline, not the release.This PR changes documentation only. The two follow-ups it names — making the aggregate gate event-aware, and requiring a Windows
lane=allat the exact promotion SHA before a release can publish — belong to the CI-integrity work and are not in this change.Verification
Documentation only; no source, test, or workflow file is touched. No local suite, typecheck, build, or install was run.
The corrected facts were each read from the GitHub API rather than from memory:
gh run view 35131181996andgh run view 35133242171both reportwindows ${{ matrix.shard }}/6 = skipped.gh run view 35134620067reports six individualwindows N/6 = successat1504caaa83.gh run view 35139132889reports six individualwindows N/6 = successat44de45dfdc..github/workflows/ci.ymlplatform-windows.ifand the aggregate gate's skip rationale confirm the mechanism.Checklist
devSummary by CodeRabbit