Skip to content

docs(devlog): close the devin-cli account-provider unit - #4348

Merged
lidge-jun merged 1 commit into
devfrom
codex/devin-cli-unit-close
Sep 12, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/devin-cli-unit-close

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes the implementation unit for #4335, which merged as b09ef15c6f. The unit directory moves from _plan/ to _fin/ and gains 090_outcome.md: what shipped, the evidence, and what did not work.

The outcome record is worth reading for one reason. Three audit rounds were spent refining a design that kept the ACP transport and invented a marker credential so the provider could have an account row without holding a token. Reviewers killed it in stages — the request path would have 401'd every turn until someone clicked Login, the stdin design could not deliver the one-time code it also required, the label surface was the wrong file.

What ended it was a measurement, not an argument: the CLI's credentials.toml holds an ordinary devin-session-token, and feeding it to the client already in this tree returned a real answer. Every blocker downstream of "there is no credential we may hold" then evaporated, including two that had already been patched around. The superseded 010/020/030 docs stay in the unit as that audit trail.

Docs only. No source change.

Verification

git diff --stat origin/dev...HEAD -- src gui tests scripts is empty for this commit; it touches devlog/ alone.

Repository-wide bun run test and bun run typecheck: NOT RUN locally, per the operator constraint for this session. Nothing in the build, typecheck, or test path reads from devlog/.

Checklist

  • Targets dev
  • Docs-only; no source, test, or build input touched
  • Unit archived to _fin/ with a terminal outcome recorded
  • Local full suite / typecheck (deferred to CI by operator instruction)

Summary by CodeRabbit

  • New Features

    • Added Devin CLI as an account provider in the Accounts section.
    • Existing Devin CLI credentials can be imported for authentication.
    • Devin CLI requests now use the cloud connection and support live model access.
    • Provider-specific account configuration improves tenant selection.
  • Documentation

    • Updated adapter documentation and localized guidance to explain Devin CLI setup, credential import, and one-time sign-in requirements.
    • Clarified the distinction between Devin and Devin CLI connections.

Merged as b09ef15. Records what shipped, the evidence, and the design that
died: three audit rounds refined a plan whose central premise — that there was no
credential opencodex could hold — nobody had tested, and the test took a minute.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 12, 2026 04:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-12T04:49:22.478467Z d5dbc99 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun merged commit d6fb871 into dev Sep 12, 2026
5 of 7 checks passed
@lidge-jun
lidge-jun deleted the codex/devin-cli-unit-close branch September 12, 2026 04:47
@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6ecf4d38-4047-4028-af74-f696601f0183

📥 Commits

Reviewing files that changed from the base of the PR and between 75d3e5c and d5dbc99.

📒 Files selected for processing (15)
  • devlog/_fin/260912_devin_cli_account_login/000_plan.md
  • devlog/_fin/260912_devin_cli_account_login/001_cli_auth_survey.md
  • devlog/_fin/260912_devin_cli_account_login/002_audit_resolution.md
  • devlog/_fin/260912_devin_cli_account_login/003_blocker1_resolution.md
  • devlog/_fin/260912_devin_cli_account_login/004_live_cli_probe.md
  • devlog/_fin/260912_devin_cli_account_login/005_cli_key_is_a_real_credential.md
  • devlog/_fin/260912_devin_cli_account_login/006_prior_art.md
  • devlog/_fin/260912_devin_cli_account_login/007_reference_proxy_corroboration.md
  • devlog/_fin/260912_devin_cli_account_login/010_phase1_cli_login.md
  • devlog/_fin/260912_devin_cli_account_login/011_phase1_credential_import.md
  • devlog/_fin/260912_devin_cli_account_login/020_phase2_reclassify.md
  • devlog/_fin/260912_devin_cli_account_login/021_phase2_oauth_and_transport.md
  • devlog/_fin/260912_devin_cli_account_login/030_phase3_surface_and_land.md
  • devlog/_fin/260912_devin_cli_account_login/031_phase3_surface_and_land.md
  • devlog/_fin/260912_devin_cli_account_login/090_outcome.md

📝 Walkthrough

Walkthrough

The change documents the Devin CLI provider from initial planning through credential-file import, provider-scoped cloud transport, OAuth registration, dashboard labeling, documentation, verification, and the recorded merge outcome.

Changes

Devin CLI account provider

Layer / File(s) Summary
Discovery and design revision
devlog/_fin/260912_devin_cli_account_login/000_plan.md, devlog/_fin/260912_devin_cli_account_login/001_cli_auth_survey.md, devlog/_fin/260912_devin_cli_account_login/002_audit_resolution.md, devlog/_fin/260912_devin_cli_account_login/003_blocker1_resolution.md, devlog/_fin/260912_devin_cli_account_login/004_live_cli_probe.md, devlog/_fin/260912_devin_cli_account_login/005_cli_key_is_a_real_credential.md, devlog/_fin/260912_devin_cli_account_login/006_prior_art.md, devlog/_fin/260912_devin_cli_account_login/007_reference_proxy_corroboration.md
The planning and audit records establish OAuth provider admission, CLI status behavior, credential-file locations, provider label routing, and the replacement of the ACP marker design with credential import and Connect-RPC transport.
Credential import and provider routing
devlog/_fin/260912_devin_cli_account_login/010_phase1_cli_login.md, devlog/_fin/260912_devin_cli_account_login/011_phase1_credential_import.md
The phase-one plans define credential parsing, login behavior, disabled refresh, provider-scoped API-server selection, adapter-factory context propagation, and focused tests.
OAuth registration and transport
devlog/_fin/260912_devin_cli_account_login/020_phase2_reclassify.md, devlog/_fin/260912_devin_cli_account_login/021_phase2_oauth_and_transport.md
The phase-two plans define the devin-cli OAuth registry entry, cloud devin adapter routing, disabled dashboard presets, legacy auth-mode migration, ACP custom-provider handling, and provider tests.
Dashboard, documentation, and outcome
devlog/_fin/260912_devin_cli_account_login/030_phase3_surface_and_land.md, devlog/_fin/260912_devin_cli_account_login/031_phase3_surface_and_land.md, devlog/_fin/260912_devin_cli_account_login/090_outcome.md
The phase-three plans define the Devin CLI dashboard label, localized documentation, runtime verification, landing workflow, and evidence for the merged provider implementation.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/devin-cli-unit-close

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 12, 2026
agentHits pushed a commit to agentHits/opencodex that referenced this pull request Sep 17, 2026
Merged as 336ebd4. Records what shipped, the evidence, and the design that
died: three audit rounds refined a plan whose central premise — that there was no
credential opencodex could hold — nobody had tested, and the test took a minute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant