Repository navigation
fix(codex): list gpt-6-astra unconditionally so the request reaches upstream - #3410
Conversation
…pstream Entitlement gating hid gpt-6-astra on every install: the slug is a preemptive leak-based registration, so no authenticated /models roster reports it, and availableAccountGatedNativeModels therefore filtered it out of the catalog, /v1/models, the dashboard rows and the desktop projection alike. Remove it from ACCOUNT_GATED_NATIVE_OPENAI_MODELS and add it to DOCUMENTED_NATIVE_OPENAI_ADDITIONS so installs with a live codex-rs catalog keep the row too. Selecting it now dispatches gpt-6-astra upstream and surfaces the real upstream status instead of silently omitting the model. disabledModels remains the visibility lever.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe catalog pre-registers ChangesGPT-6 Astra registration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ngate fix(codex): list gpt-6-astra unconditionally so the request reaches upstream
…ngate fix(codex): list gpt-6-astra unconditionally so the request reaches upstream
Summary
gpt-6-astraunconditionally instead of hiding it behind account entitlement./modelsroster reports it yet. Entitlement gating therefore filtered it out of the Codex catalog,/v1/models, the dashboard rows and the desktop projection on every install, including the accounts meant to try it.ACCOUNT_GATED_NATIVE_OPENAI_MODELSand add it toDOCUMENTED_NATIVE_OPENAI_ADDITIONSso installs that do have a live codex-rs catalog keep the row as well.gpt-6-astraupstream and surfaces the real upstream status rather than silently omitting the model.disabledModelsremains the user visibility lever.Verification
bun test tests/native-model-toggle.test.ts tests/codex-catalog.test.ts— 303 pass, 0 fail.bun test tests/codex-catalog-sync-hardening.test.ts tests/codex-model-entitlements.test.ts tests/model-visibility-management-api.test.ts tests/vision-reasoning-contract.test.ts tests/claude-desktop-native-context.test.ts— 90 pass, 0 fail.bun run typecheck— clean.ocx service:/v1/modelsnow listsgpt-6-astra, and a chat completion against it reaches the Codex credential path instead of being filtered out of the catalog.Checklist
Summary by CodeRabbit
New Features
Tests