Skip to content

fix(codex): list gpt-6-astra unconditionally so the request reaches upstream - #3410

Merged
lidge-jun merged 1 commit into
devfrom
codex/260904-astra-ungate
Sep 4, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/260904-astra-ungate

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • List gpt-6-astra unconditionally instead of hiding it behind account entitlement.
  • The slug is a preemptive leak-based registration, so no authenticated /models roster reports it yet. Entitlement gating therefore filtered it out of the Codex catalog, /v1/models, the dashboard rows and the desktop projection on every install, including the accounts meant to try it.
  • Remove it from ACCOUNT_GATED_NATIVE_OPENAI_MODELS and add it to DOCUMENTED_NATIVE_OPENAI_ADDITIONS so installs that do have a live codex-rs catalog keep the row as well.
  • Selecting it now dispatches gpt-6-astra upstream and surfaces the real upstream status rather than silently omitting the model. disabledModels remains the user visibility lever.

Verification

  • bun test tests/native-model-toggle.test.ts tests/codex-catalog.test.ts — 303 pass, 0 fail.
  • bun test tests/codex-catalog-sync-hardening.test.ts tests/codex-model-entitlements.test.ts tests/model-visibility-management-api.test.ts tests/vision-reasoning-contract.test.ts tests/claude-desktop-native-context.test.ts — 90 pass, 0 fail.
  • bun run typecheck — clean.
  • Live proxy on port 10100 after ocx service: /v1/models now lists gpt-6-astra, and a chat completion against it reaches the Codex credential path instead of being filtered out of the catalog.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • New Features

    • Added GPT-6 Astra to the available native model catalog.
    • GPT-6 Astra is now listed without account entitlement gating and can be dispatched using its native model identifier.
    • Existing disabled-model settings continue to hide GPT-6 Astra when configured.
  • Tests

    • Added coverage verifying GPT-6 Astra visibility, native capabilities, identifier handling, and disabled-model behavior.

…pstream

Entitlement gating hid gpt-6-astra on every install: the slug is a preemptive leak-based registration, so no authenticated /models roster reports it, and availableAccountGatedNativeModels therefore filtered it out of the catalog, /v1/models, the dashboard rows and the desktop projection alike.

Remove it from ACCOUNT_GATED_NATIVE_OPENAI_MODELS and add it to DOCUMENTED_NATIVE_OPENAI_ADDITIONS so installs with a live codex-rs catalog keep the row too. Selecting it now dispatches gpt-6-astra upstream and surfaces the real upstream status instead of silently omitting the model. disabledModels remains the visibility lever.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 4, 2026 00:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-04T00:05:54.765961Z 6f634ed PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 4, 2026
@lidge-jun
lidge-jun merged commit db2e2eb into dev Sep 4, 2026
21 of 26 checks passed
@lidge-jun
lidge-jun deleted the codex/260904-astra-ungate branch September 4, 2026 00:04
@coderabbitai

coderabbitai Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 10af4352-b0d7-4ec8-8dd3-e3171693fc71

📥 Commits

Reviewing files that changed from the base of the PR and between 9c29e44 and 6f634ed.

📒 Files selected for processing (4)
  • src/codex/catalog/metadata.ts
  • src/codex/catalog/native-models.ts
  • tests/codex-catalog.test.ts
  • tests/native-model-toggle.test.ts

📝 Walkthrough

Walkthrough

The catalog pre-registers gpt-6-astra as an ungated native model. Tests verify its catalog visibility, entitlement status, native capabilities, wire identity, and disabledModels filtering.

Changes

GPT-6 Astra registration

Layer / File(s) Summary
Astra registration and gating behavior
src/codex/catalog/metadata.ts, src/codex/catalog/native-models.ts
gpt-6-astra is added to documented native additions. Its comment documents non-gated registration and upstream dispatch behavior.
Astra registration validation
tests/codex-catalog.test.ts, tests/native-model-toggle.test.ts
Tests verify that Astra is absent from the account-gated set, present in native model outputs, and hidden when listed in disabledModels.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: wibias

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/260904-astra-ungate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant