Repository navigation
fix(models): preserve empty providers and discovery controls - #313
Merged
Merged
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 23, 2026
3 tasks done
3 tasks done
agentHits
pushed a commit
to agentHits/opencodex
that referenced
this pull request
Sep 17, 2026
…very-empty-providers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two related model-discovery failures:
defaultModelwhen live/modelsdiscovery fails and no staticmodels[]exists (新增自定义提供商,如果适配器选用anthropic则看不到模型 #308);liveModelscan now be changed from Provider Settings (Feature: Provider model discovery control and empty provider visibility #310).Root cause
fetchProviderModels()called the failure pathfallback=configured, but the configured fallback was built only frommodels[]; a callable AnthropicdefaultModelwas discarded. Separately, the Models page derived provider groups exclusively from/api/models, so a zero-row provider had no UI identity. The backend honoredliveModelsbut its field-mask PATCH and normal Settings UI did not expose it.Changes
defaultModelonly as a failed-live-discovery fallback; successful live catalogs remain authoritative andliveModels:falsewith an empty static list still publishes zero rows.liveModelsPATCH support and non-secret provider discovery metadata.Validation
bun run test: 3,614 passed, 0 failedbun run typecheckbun run privacy:scanbun run lint:guibun run build:guiFixes #308
Fixes #310