Skip to content

fix(models): preserve empty providers and discovery controls - #313

Merged
Ingwannu merged 1 commit into
devfrom
agent/fix-model-discovery-empty-providers
Jul 23, 2026
Merged

Ingwannu merged 1 commit into
devfrom
agent/fix-model-discovery-empty-providers

Conversation

@Ingwannu

Copy link
Copy Markdown
Owner

Summary

Fixes two related model-discovery failures:

Root cause

fetchProviderModels() called the failure path fallback=configured, but the configured fallback was built only from models[]; a callable Anthropic defaultModel was discarded. Separately, the Models page derived provider groups exclusively from /api/models, so a zero-row provider had no UI identity. The backend honored liveModels but its field-mask PATCH and normal Settings UI did not expose it.

Changes

  • Use an Anthropic-compatible defaultModel only as a failed-live-discovery fallback; successful live catalogs remain authoritative and liveModels:false with an empty static list still publishes zero rows.
  • Add strict boolean liveModels PATCH support and non-secret provider discovery metadata.
  • Add a Provider Settings live-discovery switch.
  • Merge configured provider metadata into Models-page grouping and render explicit zero-model guidance for discovery-on and discovery-off states.
  • Exclude disabled and empty forward-only providers from those groups.
  • Add six-locale UI strings and dashboard documentation.

Validation

  • bun run test: 3,614 passed, 0 failed
  • bun run typecheck
  • bun run privacy:scan
  • bun run lint:gui
  • bun run build:gui
  • focused API/catalog/grouping/SSR tests

Fixes #308
Fixes #310

@github-actions github-actions Bot added the bug Something isn't working label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 74e8e1fb-9183-4882-96b4-5b33ce6fb0af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-model-discovery-empty-providers

Comment @coderabbitai help to get the list of available commands.

@Ingwannu
Ingwannu merged commit d56d294 into dev Jul 23, 2026
10 checks passed
@lidge-jun
lidge-jun deleted the agent/fix-model-discovery-empty-providers branch July 23, 2026 08:09
agentHits pushed a commit to agentHits/opencodex that referenced this pull request Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant