test(native-profile): bound hosted macOS busy-probe case - #1575
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe rollback and busy-process tests now document setup timing on hosted macOS. Both test timeouts increase from Bun’s default to 10 seconds. ChangesNative profile test stability
Estimated code review effort: 1 (Trivial) | ~3 minutes Mergeability Score: ⚪ Minimal · up to This change only gives a flaky hosted-macOS test a bounded 10-second harness budget while leaving product timeout and runtime behavior unchanged; no actionable merge-blocking risk remains. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The first exact-head run did not fail the changed native-profile case. GitHub annotated the unrelated existing |
|
Correction: this environment's GitHub CLI does not support selecting only failed jobs, so the prior rerun command was rejected and changed nothing. I have now started one full exact-head rerun of run |
|
The exact-head macOS rerun exposed the same harness-boundary issue in the adjacent rollback verification: the product assertions completed correctly, but hosted macOS took 7.8 s and Bun's 5 s default expired. I added a documented 10 s budget only to that rollback regression; the product's lock and recovery deadlines are unchanged. Local validation on exact head |
|
Exact-head CI is now fully green at |
Wibias
left a comment
There was a problem hiding this comment.
No code blocker from my review. This stays scoped to the test harness: the 10s budget is documented next to the affected cases, while the product lock/process behavior remains unchanged. The exact head also went green across the repository CI matrix, including the hosted macOS suite that reproduced the flake.
Please rebase onto current dev and rerun CI; assuming that stays green, this is good to merge.
Summary
CODEX_BUSYbehavior unchangedCloses #1563
Verification
Focused result: 5/5 passes. Typecheck and privacy scan are green.
Checklist
Summary by CodeRabbit