Skip to content

test(ci): accept the Copilot permission in the issue-quality workflow pin - #1113

Merged
Wibias merged 1 commit into
devfrom
codex/fix-ci-issue-quality-permission-test
Aug 6, 2026
Merged

Wibias merged 1 commit into
devfrom
codex/fix-ci-issue-quality-permission-test

Conversation

@Wibias

@Wibias Wibias commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Fix the issue-quality CI test pinning the pre-Copilot permission

The translate job in .github/workflows/enforce-issue-quality.yml migrated from the actions/ai-inference action (which needed models: read) to the GitHub Copilot CLI (which needs copilot-requests: write) in 3a7a72d8 (migrate issue automation to Copilot). The regression test in tests/ci-workflows.test.ts was not updated and still pins models: read, so the test 1/4 CI job fails on every PR against current dev.

Change

The test's real guard is that the translate job stays job-scoped — no top-level issues: write, no actions: write. The permission-name pin is secondary, so the assertion now accepts either the legacy models: read or the current copilot-requests: write, keeping the job-scoped guard intact.

-      /jobs:\s*\n\s*translate:[\s\S]*?permissions:\s*\n(?:\s*#.*\n)*\s*contents: read\s*\n(?:\s*#.*\n)*\s*issues: write\s*\n(?:\s*#.*\n)*\s*models: read/,
+      /jobs:\s*\n\s*translate:[\s\S]*?permissions:\s*\n(?:\s*#.*\n)*\s*contents: read\s*\n(?:\s*#.*\n)*\s*issues: write\s*\n(?:\s*#.*\n)*\s*(?:copilot-requests: write|models: read)/,

Verification

  • tests/ci-workflows.test.ts — all 113 tests pass (was 1 fail on the head).
  • bun run typecheck green.

Summary by CodeRabbit

  • Tests
    • Updated workflow validation to support the newly available permission option for issue translation, while preserving existing required permissions.

… pin

The issue-quality workflow's translate job migrated from the
actions/ai-inference permission (models: read) to the Copilot CLI
permission (copilot-requests: write) in 3a7a72d, but the regression
test still pinned models: read. The test was guarding that the job
stays job-scoped (no top-level issues:write, no actions:write), so it
now accepts either permission name and keeps that guard.
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fb83e9f6-4735-4e7b-8d53-70cc0fde0ed3

📥 Commits

Reviewing files that changed from the base of the PR and between ef13178 and 97c973e.

📒 Files selected for processing (1)
  • tests/ci-workflows.test.ts

📝 Walkthrough

Walkthrough

The issue-translation workflow permission test now accepts either models: read or copilot-requests: write, while retaining contents: read and issues: write.

Changes

CI workflow permissions

Layer / File(s) Summary
Update translation permission assertion
tests/ci-workflows.test.ts
At line 4145, the test accepts either models: read or copilot-requests: write alongside contents: read and issues: write.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: ingwannu, lidge-jun

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-ci-issue-quality-permission-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias merged commit a5b3782 into dev Aug 6, 2026
17 of 18 checks passed
@Wibias
Wibias deleted the codex/fix-ci-issue-quality-permission-test branch August 6, 2026 09:24
agentHits pushed a commit to agentHits/opencodex that referenced this pull request Sep 17, 2026
…uality-permission-test

test(ci): accept the Copilot permission in the issue-quality workflow pin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant