Repository navigation
fix: issue sweep — tests badge floor in CI, path-independent budgets, Node 22 timer tests, audit guidance; drop preview - #325
Merged
Conversation
…m the README CI table
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 27, 2026
lidge-jun
added a commit
that referenced
this pull request
Oct 27, 2026
docs(plan): issue sweep delivery record (#325)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #301, closes #297, closes #296, closes #294. Also removes the dead
previewbranch from CI.preview cleanup. The
previewbranch no longer exists. It is dropped from the CI and WSL push filters, the closed-PR branch cleanup's protected list (and its tests), and the README CI table.mainstays:codex plugin marketplace addwithout--refinstalls the default branch, somainis the release channel.#301 tests badge.
inventory.mjs --check --tests Nnow accepts--tests-mode exact|floor, defaulting toexact. PR/dev CI usesfloor. A badge that lags behind newly added tests prints::noticewith the exactinventory.mjs --write --tests Ncommand and passes. Only a badge that claims more tests than ran fails. Before, every PR that added tests failed CI until a badge-bump commit, and parallel PRs conflicted on that line. The release gate (release-gate.ts) still compares exactly.check()gains an additivenoticesfield. A trailing--tests-modewith no value, an unknown mode, or a mode without--testsexits 1.#297 byte budgets.
l1-injections(V2 skill affordance) andworktree-guard(rename guidance) measured prompt text that embeds an absolute path, so the tests failed on machines with long checkout or temp paths (worktree-guard failed on every run on this mac). Both now replace the root with a placeholder before measuring. New cases use short and long synthetic roots. Prose growth is still caught (a reviewer check showed 180→540 B and 154→514 B both fail).#296 Node 22 cancellations. This is a Node-version effect: it does not come from tests interacting in a single process. On Node 22.22.0,
media-handler,rate-limitandmcptests await promises kept alive only byunref()'d timers (stream-download.ts,rate-limit.ts,mcp.ts). Node 22's runner sees an empty event loop and cancels the test plus the rest of its file. Node 24/26 keep waiting, which is why hosted CI was green. Those six tests now hold one referenced interval for their own lifetime and carry a 10 s timeout, so the hold cannot hide a hang. Productionunref()calls are intentional and unchanged. Before: the three files on Node 22.22.0 gave 34 tests, 8 cancelled. After: 34 passed, 0 cancelled.#294 Audit guidance (docs only, agreed scope).
phase-audit.mdadds three rules. AUDIT-REAUDIT-SCOPE-01: a re-audit checks blocker closure and amendment regressions; new Low/Medium findings become residuals; a new High/Critical is still folded or rebutted. REBUTTAL-BASIS-01: High/Critical rebuttals name a command orpath:linewhen one exists. AUDIT-REVIEWER-ROLE-01: small reviewers do fact checks; prefer the strongest reviewer for substantial design. Same-reviewer reuse stays the default.loop-engineering.mdandstructure/20point at them. Not adopted from the issue: reviewer-tier rule, fresh-reviewer rotation, rebuttal-outcome ledger, gate/attest changes. Fresh-reviewer rotation is what produced endless nit rounds in practice.Validation
cxc receipt test -- npm test) at the head: tests 3879, pass 3873, fail 0, cancelled 0, skipped 6 (8b1c7ed).inventory.mjs --checkandgate.mjsexit 0. Release-gate tests 38/38.devlog/_plan/261027_issue_sweep/.