Skip to content

linux: Drop workaround for kernel < 2.6.34#39

Merged
Youw merged 1 commit into
libusb:masterfrom
z3ntu:legacy-code-linux
Jul 15, 2019
Merged

linux: Drop workaround for kernel < 2.6.34#39
Youw merged 1 commit into
libusb:masterfrom
z3ntu:legacy-code-linux

Conversation

@z3ntu
Copy link
Copy Markdown
Collaborator

@z3ntu z3ntu commented Jul 3, 2019

Also drop HIDIOC* definitions as they are present since kernel 2.6.39.

Also drop HIDIOC* definitions as they are present since kernel 2.6.39.
@Youw
Copy link
Copy Markdown
Member

Youw commented Jul 3, 2019

where do we define minimum supported kernel?

@z3ntu
Copy link
Copy Markdown
Collaborator Author

z3ntu commented Jul 3, 2019

Nowhere as far as I know. But I guess everything above 2.6.39 should work now, but I haven't tested that. And as this version is so old, I don't think it's necessary to document this as it should *just work* on any halfway recent Linux kernel.

@Youw
Copy link
Copy Markdown
Member

Youw commented Jul 3, 2019

I still think it worth adding at least README notice. Would you?

@z3ntu
Copy link
Copy Markdown
Collaborator Author

z3ntu commented Jul 3, 2019

If you're willing to test hidapi on e.g. kernel 2.6.39 then sure; but other than downloading the oldest supported CentOS version (disclaimer: I just know that they have super old kernels but I have no idea what version) I wouldn't even know how to get a VM running kernel 2.6.39

@Youw
Copy link
Copy Markdown
Member

Youw commented Jul 3, 2019

Hm, good point - don't want to check/make any assures on support.
What about:
"Don't try to compile with Kernel older than 2.6.39 - it won't".

As usual, there will be that one person, who will try and open a bug.

@z3ntu
Copy link
Copy Markdown
Collaborator Author

z3ntu commented Jul 3, 2019

As usual, there will be that one person, who will try and open a bug.

I'd say, if someone opens a bug report for that, we can add it to the readme 😉

@Youw Youw requested review from Qbicz, jdk and todbot July 9, 2019 13:41
@Youw Youw merged commit 6f79625 into libusb:master Jul 15, 2019
@z3ntu z3ntu deleted the legacy-code-linux branch July 15, 2019 12:08
@mcuee mcuee added the hidraw Related to Linux/hidraw backend label Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hidraw Related to Linux/hidraw backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants