support multiple usage/usage-pages on macOS, update of @fengj2006 PR#65 #124
Closed
todbot wants to merge 2 commits into
Closed
support multiple usage/usage-pages on macOS, update of @fengj2006 PR#65 #124todbot wants to merge 2 commits into
todbot wants to merge 2 commits into
Conversation
Youw
reviewed
Nov 26, 2019
Youw
reviewed
Nov 26, 2019
|
|
||
| static int set_report(hid_device *dev, IOHIDReportType type, const unsigned char *data, size_t length) | ||
| { | ||
| const unsigned char *data_to_send = data; |
Member
Contributor
Author
There was a problem hiding this comment.
oh! okay I will not try to use any merge tools and instead re-do this PR by hand. I didn't think fengj2006's original PR was so far back in time. sigh.
Member
There was a problem hiding this comment.
yeah, I guess it was
a hint:
- checkout fengj2006's branch
- save a diff only:
git diff HEAD~1 > diff.diff
so it only contain a relevant changes - checkout to
origin/master - apply diff:
git apply diff.diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this includes all the requested changes, on top of the work done by @fengj2006 on #65
You can now see all the different usages as different "devices" in
hid_enumerate(). When runninghidtestyou see them too. On a Macbook with internal keyboard/trackpad, there are many:Additionally, I've verified that an Arduino "RawHID" device with two usages shows up as two devices to hidapi
(the device is a $9 Trinket M0 running TinyUSB pretending to like Teensy in RawHID mode) You can see this here: https://github.com/todbot/hidapitester/tree/master/tinyusb_teensyrawhid_multiusage