Skip to content

[P2][ci] Add Node.js 22 smoke job to CI #32

Closed

Description

@cevheri

Summary

package.json declares Node.js engines >= 22 and documents npx usage, but CI runs Bun-only (bun run gate). Node compatibility regressions would ship unnoticed.

Audit ID: Section 2 Med — Wave 2

Fix

Add CI job (e.g. node-smoke in .github/workflows/ci.yml):

  1. actions/setup-node with Node 22
  2. bun run build (or use published tarball from npm pack)
  3. Minimal script: open({ path, fs: nodeFileSystem() }) → transact set → close → reopen → get asserts value

Keep job fast (<2 min); no full gate duplicate on Node unless desired.

Acceptance criteria

  • Node 22 job runs on PR and main.
  • Smoke test covers path-backed open/write/reopen.
  • Document in docs/TOOLCHAIN.md if needed.
  • No changeset (CI only).

Verification

Push branch; CI green on Node job.

Activity

  1. cevheri commented on Jul 3, 2026

    @cevheri
    MemberAuthor

    Implemented and shipped in PR #43 (merge commit 69f7161), released as v0.2.0. The PR description's comma-separated Closes list only auto-closed the first reference — closing manually. For #39/#28-style partials: the shipped scope is done; the real-browser verification half of #39 continues under #10, and the typed-error contract (#28) shipped as LibreDbError with stable codes across kernel, adapters, lenses, and CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions