Gossipsub Protocol by AgeManning · Pull Request #898 · libp2p/rust-libp2p

AgeManning · 2019-01-29T06:18:49Z

This is an implementation of the gossipsub protocol as in the libp2p-specs.

This is feature-complete, except for the control-message piggy-backing and peer-tagging, which still need to be implemented.

Currently this implementation is not backwards compatible with floodsub nodes (see #880).

Further testing and debugging will be done over the next few weeks.

…psub struct

…nd adds tests

…de and modifies GossipsubRpc

- Adds the log crate and implements logging macros - Specifies versions for external crates

- Adds basic documentation, overview and examples to the gossipsub crate.

This commit also adds the inject_connected test.

- Modifies `handle_received_subscriptions` to take a reference of subscriptions - Adds `test_subscribe` - Adds `test_handle_received_subscriptions` - Adds tests for the filter in `get_random_peers`

mxinden · 2020-01-15T11:12:17Z

Just updated sigp#22, sorry for the delay.

protocols/gossipsub: Move to stable futures

AgeManning · 2020-01-23T09:07:02Z

Ok. Stable-futures and latest master have been merged in.

tomaka

I only gave a brief looked, and I'm tempted to trust @mxinden's review when it comes to the logic.

AgeManning · 2020-01-24T02:43:09Z

Applied @tomaka's suggestions and re-merged master.

mxinden · 2020-01-24T11:22:22Z

I have another pull request following up on the inbound substream error handling discussion: sigp#24. I think the discussion is worth having. I don't think it should block this pull request.

mxinden

I only gave a brief looked, and I'm tempted to trust @mxinden's review when it comes to the logic.

I would interpret this as an approval @tomaka? Anyone else wanting to give this a review?

I have a couple of smaller comments left, but I think this is in a great merge-able state.

Thanks @AgeManning for all the hard work!

tomaka

+1 for merging! I haven't actually looked at the logic, but the general code organization and clean-ness looks code.

tomaka · 2020-01-24T12:48:49Z

@AgeManning Are we good for merging this?

AgeManning · 2020-01-24T14:33:04Z

Yep I think so. I've not updated the code base I'm using to stable futures yet, so haven't tested this version at any scale.
There may be a few more PRs to add things like message signing. But I think the current state is usable and fits better in the libp2p code base with proper versioning rather than the fork I'm maintaining.

If this sounds good to you guys, merge away :)

thomaseizinger · 2020-05-11T07:24:54Z

There may be a few more PRs to add things like message signing.

Is there already an issue tracking this somewhere? I couldn't find anything but would be interested in following it's progress and to coordinate potential contributions :)

AgeManning · 2020-05-13T13:20:31Z

@thomaseizinger
I am planning on building gossipsub 1.1. Ideally starting in a week. I can put the PR up to track if you like.
I'll add the message signing in as I go.

tomaka reviewed Jan 29, 2019

View reviewed changes

Comment thread protocols/gossipsub/src/protocol.rs Outdated

tomaka added the changelog label Jan 29, 2019

jamesray1 mentioned this pull request Jan 31, 2019

[On ice] Gossipsub: an extensible baseline pubsub protocol, based on randomized topic meshes and gossip #767

Closed

twittner reviewed Feb 1, 2019

View reviewed changes

AgeManning added 26 commits February 2, 2019 14:55

Create gossipsub crate - Basic template, borrowed from floodsub

e9b7059

Add a GossipsubConfig struct and set up basic structures in the Gossi…

e09cb3f

…psub struct

Begin implementation of join. Adds get_random_peers helper function a…

65f3211

…nd adds tests

Implements gossipsub leave()

bcef5ff

Update publishMany to incorporate gossipsub mesh and fanout logic

fb0160f

Use the gossipsub mesh for determining peer subscription

e0933dd

Remove subscribed_topics field from the Gossipsub struct

6de264e

Rename gossipsubconfig to ProtocolConfig

e3c3d0f

Implement the gossipsub control messages into the Codec's Encode/Deco…

47dbb69

…de and modifies GossipsubRpc

Modify GossipsubActions to enums for succinctness.

e05f363

Modify the memcache to store Gossipsub messages

53c364b

Implement control message handling.

cb5e20b

Update control message handling to handle multiple messages.

e865ed5

Handle received gossipsub messages using pre-built handlers.

80673d1

Remove excess connected peer hashmap

1aa63ad

Add extra peer mapping and consistent topic naming.

db345bb

Implement heartbeat, emit_gossip and send_graft_prune.

5531342

Group logic in forwarding messages. Add messages to memcache.

a29ae37

Add heartbeat timer and move location of helper function.

a85ee9a

Add gossipsub the libp2p workspace, makes layer structs public

e0142b6

Add logging to gossipsub

8cdaf6b

- Adds the log crate and implements logging macros - Specifies versions for external crates

Add example chat for debugging purposes

deccbe5

Implement libp2p#868 for gossipsub.

e69a772

Add rust documentation to gossipsub crate.

3dad3ea

- Adds basic documentation, overview and examples to the gossipsub crate.

Re-introduce the initial heartbeat time config.

77047c3

This commit also adds the inject_connected test.

Add subscribe tests.

c7b3ca5

- Modifies `handle_received_subscriptions` to take a reference of subscriptions - Adds `test_subscribe` - Adds `test_handle_received_subscriptions` - Adds tests for the filter in `get_random_peers`

mxinden added 3 commits January 15, 2020 12:04

examples/gossipsub-chat.rs: Move to stable futures

6375130

protocols/gossipsub/src/behaviour/tests: Update to stable futures

1395205

protocols/gossipsub/tests: Update to stable futures

542b100

mxinden and others added 5 commits January 20, 2020 11:30

protocols/gossipsub: Log substream errors

0c054df

protocols/gossipsub: Log outbound substream errors

93b5bb2

Merge pull request #22 from mxinden/gossipsub-stable-futures

a9e19a5

protocols/gossipsub: Move to stable futures

Merge in latest master

2b7bdbd

Remove rust-fmt formatting

684968c

tomaka reviewed Jan 23, 2020

View reviewed changes

Comment thread protocols/gossipsub/regen_structs_proto.sh Outdated

Comment thread protocols/gossipsub/src/config.rs Outdated

Comment thread protocols/gossipsub/src/protocol.rs

AgeManning added 2 commits January 24, 2020 13:40

Shift to prost for protobuf compiling

1ca966b

Merge branch 'master' into gossipsub

a565efc

Use wasm_timer for wasm compatibility

25a9636

mxinden approved these changes Jan 24, 2020

View reviewed changes

tomaka approved these changes Jan 24, 2020

View reviewed changes

Merge branch 'master' into gossipsub

1033831

tomaka merged commit 37c7d73 into libp2p:master Jan 24, 2020

artemii235 mentioned this pull request Mar 12, 2020

Give a try to libp2p gossipsub for orderbook and ordermatching messages broadcast. GLEECBTC/komodo-defi-framework#602

Closed

19 tasks

AgeManning deleted the gossipsub branch July 1, 2020 07:23

mxinden mentioned this pull request Apr 1, 2021

pubsub/gossipsub/README: Mark rust gossipsub v1.0 as complete libp2p/specs#310

Merged

AgeManning mentioned this pull request Dec 13, 2021

swarm/src/behaviour: Consider removing NetworkBehaviourAction::TInEvent #2374

Closed

AgeManning mentioned this pull request Dec 15, 2022

refactor(gossipsub): don't store messages within Arc #3243

Merged

4 tasks

mxinden mentioned this pull request Feb 13, 2023

Change sequence number in gossipsub to be linearly increasing #3453

Closed

Conversation

AgeManning commented Jan 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mxinden commented Jan 15, 2020

Uh oh!

AgeManning commented Jan 23, 2020

Uh oh!

tomaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AgeManning commented Jan 24, 2020

Uh oh!

mxinden commented Jan 24, 2020

Uh oh!

mxinden left a comment

Choose a reason for hiding this comment

Uh oh!

tomaka left a comment

Choose a reason for hiding this comment

Uh oh!

tomaka commented Jan 24, 2020

Uh oh!

AgeManning commented Jan 24, 2020

Uh oh!

thomaseizinger commented May 11, 2020

Uh oh!

AgeManning commented May 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AgeManning commented Jan 29, 2019 •

edited

Loading