Skip to content

chore: raise MSRV to 1.75#5266

Merged
mergify[bot] merged 3 commits into
libp2p:masterfrom
jxs:update-msrv
Mar 29, 2024
Merged

chore: raise MSRV to 1.75#5266
mergify[bot] merged 3 commits into
libp2p:masterfrom
jxs:update-msrv

Conversation

@jxs

@jxs jxs commented Mar 25, 2024

Copy link
Copy Markdown
Member

Description

To allow merging #5232
CC @SuperFluffy since you commented on #4692

@dariusc93

Copy link
Copy Markdown
Member

I wonder if it would make more sense to bump the msrv 1.75 due to the stabilization of async fn in traits and returning impl trait. Thoughts on that?

@jxs jxs left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Darius, makes sense. Updated to 1.75 instead

@jxs jxs added the trivial Marks PRs which are considered trivial and don't need approval from another maintainer. label Mar 29, 2024
@jxs jxs changed the title chore: bump MSRV to 1.74 chore: bump MSRV to 1.75 Mar 29, 2024
@jxs jxs changed the title chore: bump MSRV to 1.75 chore: raise MSRV to 1.75 Mar 29, 2024
@mergify

mergify Bot commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts. Could you please resolve them @jxs? 🙏

@jxs jxs added the send-it label Mar 29, 2024
@mergify mergify Bot merged commit 855ff8c into libp2p:master Mar 29, 2024
@elenaf9 elenaf9 mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants