Skip to content

*: Switch futures_codec to asynchronous-codec#1908

Merged
mxinden merged 5 commits into
libp2p:masterfrom
mxinden:asynchronous-codec
Jan 12, 2021
Merged

*: Switch futures_codec to asynchronous-codec#1908
mxinden merged 5 commits into
libp2p:masterfrom
mxinden:asynchronous-codec

Conversation

@mxinden

@mxinden mxinden commented Jan 6, 2021

Copy link
Copy Markdown
Member

futures-codec has not been updated in the recent months. It still
depends on bytes v0.5 preventing all downstream dependencies to
upgrade to bytes v1.0.

This commit replaces futures_codec in favor of asynchronous-codec
The latter is a fully upgraded fork of the former.

Closes #1900. Depends on paritytech/unsigned-varint#47.

See also matthunz/futures-codec#51 and matthunz/futures-codec#57.

In addition to the above, this pull request upgrades rust-libp2p to bytes v1.

`futures-codec` has not been updated in the recent months. It still
depends on `bytes` `v0.5` preventing all downstream dependencies to
upgrade to `bytes` `v1.0`.

This commit replaces `futures_codec` in favor of `asynchronous-codec`
The latter is a fully upgraded fork of the former.

@romanb romanb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. We should merge this before #1887, since you already made the version and changelog updates here.

Comment thread protocols/identify/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants