Finish PeerId inlining change#1413
Merged
Merged
Conversation
Member
Author
|
Substrate works after this change. |
twittner
approved these changes
Jan 27, 2020
mxinden
approved these changes
Jan 28, 2020
twittner
reviewed
Jan 28, 2020
twittner
left a comment
twittner
left a comment
Contributor
There was a problem hiding this comment.
Any particular reason why you did not use the property test from #1230 (comment)?
Member
Author
I had forgotten about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1230
Adds custom implementations of
PartialEqandHashforPeerIds so that they compare equal between hash algorithm.This is intended to be removed at some point, because the hash algorithm should be derived in a predictable way from the public key.