Allow building an upgrade from an async function#1383
Merged
Conversation
twittner
approved these changes
Jan 9, 2020
| /// return Err(upgrade::ReadOneError::from(io::Error::from(io::ErrorKind::Other))); | ||
| /// } | ||
| /// } | ||
| /// |
| { | ||
| type Output = Out; | ||
| type Error = Err; | ||
| type Future = Pin<Box<Fut>>; // TODO: don't box the future |
Contributor
There was a problem hiding this comment.
Do you want to file an issue for the TODOs in here?
Member
Author
There was a problem hiding this comment.
Will rebase on top of #1384 once it's merged.
Member
Author
|
Updated and concerns addressed! |
Member
Author
|
Any objection to merging? |
Contributor
|
Not at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quality-of-life change, with the objective of trying to make rust-libp2p easier to use.
I think it's quite nice and comprehensible to be able to write upgrades as shown in the doc-comment example.