libp2p-websocket: build error on async-tls 0.10.2

[akru]

Build log

error[E0277]: the trait bound `TlsConnector: From<Arc<ClientConfig>>` is not satisfied                               [116/1854]
  --> /home/akru/.cargo/registry/src/github.com-1ecc6299db9ec823/libp2p-websocket-0.26.0/src/tls.rs:73:47                      
   |                                                                                                                           
73 |             client: Arc::new(client_config()).into(),                                                                     
   |                                               ^^^^ the trait `From<Arc<ClientConfig>>` is not implemented for `TlsConnecto
r`                                                                                                                             
   |                                                           
   = help: the following implementations were found:                                                                           
             <TlsConnector as From<Arc<rustls::client::ClientConfig>>>                                     
             <TlsConnector as From<rustls::client::ClientConfig>>                                                              
   = note: required because of the requirements on the impl of `Into<TlsConnector>` for `Arc<ClientConfig>`                    
                                                                                                                               
error[E0277]: the trait bound `TlsConnector: From<Arc<ClientConfig>>` is not satisfied                                         
   --> /home/akru/.cargo/registry/src/github.com-1ecc6299db9ec823/libp2p-websocket-0.26.0/src/tls.rs:119:43                        |                                                                                                                          
119 |             client: Arc::new(self.client).into(),                                                                        
    |                                           ^^^^ the trait `From<Arc<ClientConfig>>` is not implemented for `TlsConnector` 
    |                                                                                                                          
    = help: the following implementations were found:                                                                          
              <TlsConnector as From<Arc<rustls::client::ClientConfig>>>                                                        
              <TlsConnector as From<rustls::client::ClientConfig>>                                                             
    = note: required because of the requirements on the impl of `Into<TlsConnector>` for `Arc<ClientConfig>`

Description

The packages build fails with async-tls v0.10.2.

[akru]

Looks like the reason is different rustls version, update to 0.19.0 should solve it.

[romanb]

See async-rs/async-tls#42.

[romanb]

libp2p-websocket-0.26.1 has been published that upgrades rustls and should thus build with async-tls-0.10.2. Since libp2p-websocket does not expose anything of rustls, we were able to make a patch release here.

[romanb]

As per the new libp2p-websocket patch release, this should be fixed. If there are still build issues after a cargo update, please let us know.

[akru]

@romanb In my opinion, the async-tls version should be strictly bonded to >= 0.10.2, because of incompatibility with the 0.10.0 release.

[romanb]

Yes, probably. See #1881.