`pnet` crate is not included in workspace but present in dependencies

[thomaseizinger]

The code in this crate is - I think - never built because it is not included in the workspace members:

rust-libp2p/Cargo.toml

Lines 100 to 125 in 421ae9d

	[workspace]
	members = [
	"core",
	"misc/core-derive",
	"misc/multiaddr",
	"misc/multistream-select",
	"misc/peer-id-generator",
	"muxers/mplex",
	"muxers/yamux",
	"protocols/floodsub",
	"protocols/gossipsub",
	"protocols/identify",
	"protocols/kad",
	"protocols/mdns",
	"protocols/noise",
	"protocols/ping",
	"protocols/plaintext",
	"protocols/request-response",
	"protocols/secio",
	"swarm",
	"transports/dns",
	"transports/tcp",
	"transports/uds",
	"transports/websocket",
	"transports/wasm-ext"
	]

It looks this is dead and outdated code? It doesn't even depend on libp2p-core?

[romanb]

Since it is a dependency of libp2p with a path, the local code does get built. The libp2p crate further exposes pub fn build_tcp_ws_pnet_noise_mplex_yamux() for development purposes. I think its neither outdated nor dead. It was probably just an oversight that it was not added to the workspace in #1385. libp2p-core was simply an unused dependency (see #1429) as the current integration of libp2p-pnet is based on AsyncRead / AsyncWrite only, as far as I can tell.

[thomaseizinger]

Thanks for the answer @romanb !

I should have looked further into it then! I opened the issue because my IDE flagged this code as not being included anywhere hence the assumption that it is actually not being built.