Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

fix: allocate "any" socket type then cast#20

Merged
Stebalien merged 1 commit into
masterfrom
fix/19
Apr 24, 2021
Merged

fix: allocate "any" socket type then cast#20
Stebalien merged 1 commit into
masterfrom
fix/19

Conversation

@Stebalien

Copy link
Copy Markdown
Member

Otherwise, we're casting from a smaller type to a bigger type, addressing memory that's not ours.

fixes #19

Otherwise, we're casting from a smaller type to a bigger type,
addressing memory that's not ours.

fixes #19
@Stebalien Stebalien requested a review from aschmahmann April 22, 2021 08:27
@aschmahmann

Copy link
Copy Markdown

Is the CI failure here related to ongoing CI changes? LGTM though

@Stebalien Stebalien merged commit 294479d into master Apr 24, 2021
@Stebalien

Copy link
Copy Markdown
Member Author

Nah, it's because we have both circle & travis and broke circle. We'll get this into the normal CI soon.

@Stebalien Stebalien mentioned this pull request May 11, 2021
27 tasks
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows - converted pointer straddles multiple allocations

2 participants