option for custom dns resolver#1073
Merged
Merged
Conversation
7 tasks
9 tasks
Stebalien
reviewed
Apr 14, 2021
Stebalien
left a comment
Stebalien
left a comment
Member
There was a problem hiding this comment.
Don't we actually need to use the resolver somewhere?
Contributor
Author
|
the code is already there AFAICT, we just needed to add it to the basic host opts in config. Did I miss that? |
vyzo
commented
Apr 14, 2021
| NATManager: cfg.NATManager, | ||
| EnablePing: !cfg.DisablePing, | ||
| UserAgent: cfg.UserAgent, | ||
| MultiaddrResolver: cfg.MultiaddrResolver, |
Stebalien
approved these changes
Apr 14, 2021
Stebalien
left a comment
Stebalien
left a comment
Member
There was a problem hiding this comment.
I guess we just never wired this up...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.